test: reconcile pg-erd refused-origin recovery on integrated runtime parent - #119
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-exact technical review on cd48f3b107e53aad647629cdd1d5800ba07495d7 (COMMENT only; not approval). The branch is rooted directly at integrated #16 bf38bc571dbb7c75e651bcaccdc66904c8c92dab with behind 0 and an effective three-path delta only: CHANGELOG.md, TEST_STRATEGY.md, and tests/pg_erd_upstream_failure_traffic.rs. The historical #17 refusal behavior is preserved, while stale fixture mechanics were repaired rather than replayed: traffic/metrics socket reservations remain owned through config construction, readiness is HTTP 200 on /readyz and /metrics, backend refusal ownership is established before process start and retained, and frontend header receipt is bounded by 5s/64 KiB. No product auth/business logic, retry/failover, route authority, Keyverse/Wardnet/EgressWeave authority, production Rust, #61-owned baseline, or TRACEABILITY delta is introduced. CI 35437243478 and Supply Chain 35437243510 are fresh on this exact and currently queued; no GREEN, merge, release, canary or cutover credit is claimed until they complete.
40e1060
into
fix/pg-erd-listener-wildcard-collision-v1
Adopt integrated #119 as the current parent without force-pushing or replaying stale predecessor state. The valid read-stall child delta is reapplied in follow-up ordinary commits on this fast-forward lineage.
Preserve the validated Max-Forwards tree as first-parent state while recording integrated #119 as the additional parent. The parent-only refused-origin fixture/docs are composed in follow-up ordinary commits; no force-push or destructive rebase.
Preserve the validated process-health tree as first-parent state while recording integrated #119 as the additional parent. Parent-only refused-origin test/docs are composed in follow-up ordinary commits; no force-push or destructive rebase.
Preserve the validated private-rustdoc tree as first-parent state while recording integrated #119 as the additional parent. Parent-only refused-origin test/docs are composed in follow-up ordinary commits; no force-push or destructive rebase.
Successor to historical #17 after #16 normally integrated as
bf38bc571dbb7c75e651bcaccdc66904c8c92dabintofix/pg-erd-listener-wildcard-collision-v1.This branch was rooted directly at that integrated parent and carried only the still-valid refused-origin evidence slice plus directly affected documentation. Historical #17 merge oracle #118 was closed unmerged after GitHub reported conflicts; no force-push or destructive rebase was used.
The successor repaired stale fixture mechanics while preserving the same authority: gateway/metrics ports remain held by
TcpListenerreservations through configuration construction and are released only at the child-bind handoff; startup requires real HTTP 200 from/readyzand/metrics; the backend authority is transferred to a bound-but-non-listening Linux TCP socket and directECONNREFUSEDis proven before gateway traffic; frontend header receipt is bounded by a five-second absolute deadline and 64 KiB ceiling. Acceptance remains HTTP 502 within the conservative one-second envelope around configured 200/400 ms connection budgets,/readyz200, exactly onecwl_pingora_gateway_request_errors_totalsample, and successful independent frontend recovery. No retry/failover/product auth/business logic/Keyverse/Wardnet/EgressWeave authority was added.Exact
cd48f3b107e53aad647629cdd1d5800ba07495d7completed CI35437243478SUCCESS across test/OCI/load and Supply Chain35437243510SUCCESS. There were no unresolved review threads; the current-range review was COMMENT-only and did not substitute self-approval. Organization rules requiring approval/required workflows apply to the default branch, not this stacked non-default base.The PR normally integrated at expected head as merge commit
40e10607601bf9722d642d4a4bb18f02806c20ccwithout force-push, destructive rebase, self-approval, administrator bypass or gate weakening. Historical #17 was then closed only as verified-successor disposition after complete valid delta/test/fixture/contract/evidence inheritance was confirmed. Repository-widedocs/product-technical-gap-baseline.mdand TRACEABILITY remained #61 authority and were untouched.Downstream #18/#102/#104/#106 have since been reconciled onto this integrated parent with behind 0 and fresh exact-head gates. This merge is stacked-parent integration only; it is not protected-main promotion, immutable release, canary/shadow, rollback, cutover or legacy-removal evidence.