Skip to content

🎨 Palette: OpenAPI λ¬Έμ„œν™”λ₯Ό μœ„ν•œ μŠ€ν‚€λ§ˆ 예제 μΆ”κ°€ - #458

Closed
seonghobae wants to merge 2 commits into
developfrom
palette/openapi-examples-531394102776921066
Closed

seonghobae wants to merge 2 commits into
developfrom
palette/openapi-examples-531394102776921066

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 29, 2026 •

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: ParseQuality 및 HealthResponse Pydantic μŠ€ν‚€λ§ˆ ν•„λ“œμ— json_schema_extra 예제 값을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: λ°±μ—”λ“œ APIμ—μ„œ 개발자 κ²½ν—˜(DX)을 κ°œμ„ ν•˜κΈ° μœ„ν•΄ OpenAPI(Swagger UI) λ¬Έμ„œμ˜ 가독성과 λͺ…확성을 λ†’μ˜€μŠ΅λ‹ˆλ‹€. API μ†ŒλΉ„μžκ°€ κΈ°λŒ€λ˜λŠ” 응닡 ν˜•μ‹μ„ 더 μ‰½κ²Œ 이해할 수 μžˆμŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: μŠ€ν‚€λ§ˆ μ„€λͺ…λ§Œ 제곡되던 κΈ°μ‘΄κ³Ό 달리, Swagger UIμ—μ„œ 각 ν•„λ“œλ³„ ꡬ체적인 μ˜ˆμ‹œ(예: "success", "mineru", ["Low OCR confidence on page 3"], "ok")κ°€ ν•¨κ»˜ ν‘œμ‹œλ©λ‹ˆλ‹€.
β™Ώ Accessibility/DX: API μ†ŒλΉ„μžκ°€ λ³„λ„μ˜ λ¬Έμ„œ 확인 없이 Swagger UI μƒμ—μ„œ κΈ°λŒ€ 응닡 ν˜•μ‹μ„ μ¦‰μ‹œ νŒŒμ•…ν•  수 μžˆλ„λ‘ 직관성을 κ°•ν™”ν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 531394102776921066 started by @seonghobae

Summary by CodeRabbit

  • λ¬Έμ„œν™”
    • OpenAPI μŠ€ν‚€λ§ˆμ— μ£Όμš” 응닡 ν•„λ“œμ˜ ꡬ체적인 μ˜ˆμ‹œ 값을 μΆ”κ°€ν•΄ API λ¬Έμ„œμ˜ 이해도λ₯Ό λ†’μ˜€μŠ΅λ‹ˆλ‹€.
    • νŒŒμ‹± μƒνƒœ, νŒŒμ„œ 정보, κ²½κ³  λͺ©λ‘ 및 ν—¬μŠ€ μƒνƒœμ— λŒ€ν•œ μ˜ˆμ‹œκ°€ μ œκ³΅λ©λ‹ˆλ‹€.

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5fdbd341-08b9-4ddc-bab2-6fdc9318f140

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 387c1a9 and 59a187b.

β›” Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
πŸ“’ Files selected for processing (1)
  • .trivyignore
πŸ“ Walkthrough

Walkthrough

ParseQuality와 HealthResponse ν•„λ“œμ— OpenAPI JSON Schema μ˜ˆμ‹œ 메타데이터λ₯Ό μΆ”κ°€ν•˜κ³ , κ΄€λ ¨ ν•™μŠ΅ λ¬Έμ„œλ₯Ό κ°±μ‹ ν•©λ‹ˆλ‹€.

Changes

μŠ€ν‚€λ§ˆ μ˜ˆμ‹œ 메타데이터

Layer / File(s) Summary
응닡 μŠ€ν‚€λ§ˆ μ˜ˆμ‹œ μΆ”κ°€
src/newsdom_api/schemas.py, .jules/palette.md
ParseQuality의 status, parser, warnings 및 HealthResponse.status에 json_schema_extra μ˜ˆμ‹œ 값을 μΆ”κ°€ν•˜κ³ , OpenAPI μŠ€ν‚€λ§ˆ μ˜ˆμ‹œ κ΄€λ ¨ λ¬Έμ„œ ν•­λͺ©μ„ μΆ”κ°€ν•©λ‹ˆλ‹€.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • ContextualWisdomLab/newsdom-api#449: λ™μΌν•œ ParseQuality ν•„λ“œμ— json_schema_extra μ˜ˆμ‹œ 값을 μΆ”κ°€ν•œ λ³€κ²½κ³Ό μ½”λ“œ μˆ˜μ€€μ—μ„œ κ΄€λ ¨λ©λ‹ˆλ‹€.
πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Title check βœ… Passed 제λͺ©μ΄ μŠ€ν‚€λ§ˆ 예제 μΆ”κ°€λ‘œ OpenAPI λ¬Έμ„œν™” κ°œμ„ μ΄λΌλŠ” μ£Όμš” 변경을 μ •ν™•νžˆ μš”μ•½ν•©λ‹ˆλ‹€.
Description check βœ… Passed Summary/Why/Before-After/DXλŠ” μΆ©λΆ„ν•˜μ§€λ§Œ ν…œν”Œλ¦Ώμ˜ Git Flow target, Verification, Notes ν•­λͺ©μ΄ λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches πŸ’‘ 1
πŸ› οΈ Fix failing CI checks πŸ’‘
  • Fix failing CI checks
πŸ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/openapi-examples-531394102776921066

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ€– Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.jules/palette.md:
- Around line 4-6: Update the new β€œ2024-07-29 - OpenAPI μŠ€ν‚€λ§ˆ 예제 μΆ”κ°€λ₯Ό ν†΅ν•œ DX ν–₯상”
heading in the palette documentation to have one blank line before and after it,
separating it from adjacent paragraphs and satisfying MD022.
πŸͺ„ Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2bc98878-eafa-4012-8ad5-9c41a753fa1f

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 04491c0 and 387c1a9.

πŸ“’ Files selected for processing (2)
  • .jules/palette.md
  • src/newsdom_api/schemas.py

Comment thread .jules/palette.md
Comment on lines +4 to +6
## 2024-07-29 - OpenAPI μŠ€ν‚€λ§ˆ 예제 μΆ”κ°€λ₯Ό ν†΅ν•œ DX ν–₯상
**Learning:** λ°±μ—”λ“œ μ „μš© FastAPI ν”„λ‘œμ νŠΈμ—μ„œλŠ” Pydantic μŠ€ν‚€λ§ˆμ— `json_schema_extra={"example": ...}`λ₯Ό μΆ”κ°€ν•˜μ—¬ OpenAPI λ¬Έμ„œ ν’ˆμ§ˆμ„ λ†’μ΄λŠ” 것이 μ€‘μš”ν•œ μ‚¬μš©μž κ²½ν—˜(DX) ν–₯상 μš”μ†Œμž„μ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.
**Action:** ν–₯ν›„ Pydantic λͺ¨λΈ μž‘μ„± μ‹œ API μ†ŒλΉ„μžμ˜ 이해λ₯Ό 돕기 μœ„ν•΄ ν•„λ“œμ— ꡬ체적인 예제 값을 기본적으둜 μΆ”κ°€ν•˜λ„λ‘ ν•©λ‹ˆλ‹€.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ“ Maintainability & Code Quality | 🟑 Minor | ⚑ Quick win

ν—€λ”© μ•žλ’€μ— 빈 쀄을 μΆ”κ°€ν•΄ μ£Όμ„Έμš”.

Line 4의 μƒˆ ## 헀딩이 μ•žλ’€ 문단과 λ°”λ‘œ λΆ™μ–΄ μžˆμ–΄ MD022 κ²½κ³ κ°€ λ°œμƒν•©λ‹ˆλ‹€. ν—€λ”© 전후에 빈 쀄을 μΆ”κ°€ν•΄ μ£Όμ„Έμš”.

μˆ˜μ • μ˜ˆμ‹œ
 **Action:** ν–₯ν›„ Pydantic λͺ¨λΈ μž‘μ„± μ‹œ API μ†ŒλΉ„μžμ˜ 이해λ₯Ό 돕기 μœ„ν•΄ ν•„λ“œμ— ꡬ체적인 예제 값을 기본적으둜 μΆ”κ°€ν•˜λ„λ‘ ν•©λ‹ˆλ‹€.
 
+ 
 ## 2024-07-29 - OpenAPI μŠ€ν‚€λ§ˆ 예제 μΆ”κ°€λ₯Ό ν†΅ν•œ DX ν–₯상
+
 **Learning:** λ°±μ—”λ“œ μ „μš© FastAPI ν”„λ‘œμ νŠΈμ—μ„œλŠ” Pydantic μŠ€ν‚€λ§ˆμ— `json_schema_extra={"example": ...}`λ₯Ό μΆ”κ°€ν•˜μ—¬ OpenAPI λ¬Έμ„œ ν’ˆμ§ˆμ„ λ†’μ΄λŠ” 것이 μ€‘μš”ν•œ μ‚¬μš©μž κ²½ν—˜(DX) ν–₯상 μš”μ†Œμž„μ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.
πŸ“ Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## 2024-07-29 - OpenAPI μŠ€ν‚€λ§ˆ 예제 μΆ”κ°€λ₯Ό ν†΅ν•œ DX ν–₯상
**Learning:** λ°±μ—”λ“œ μ „μš© FastAPI ν”„λ‘œμ νŠΈμ—μ„œλŠ” Pydantic μŠ€ν‚€λ§ˆμ— `json_schema_extra={"example": ...}`λ₯Ό μΆ”κ°€ν•˜μ—¬ OpenAPI λ¬Έμ„œ ν’ˆμ§ˆμ„ λ†’μ΄λŠ” 것이 μ€‘μš”ν•œ μ‚¬μš©μž κ²½ν—˜(DX) ν–₯상 μš”μ†Œμž„μ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.
**Action:** ν–₯ν›„ Pydantic λͺ¨λΈ μž‘μ„± μ‹œ API μ†ŒλΉ„μžμ˜ 이해λ₯Ό 돕기 μœ„ν•΄ ν•„λ“œμ— ꡬ체적인 예제 값을 기본적으둜 μΆ”κ°€ν•˜λ„λ‘ ν•©λ‹ˆλ‹€.
## 2024-07-29 - OpenAPI μŠ€ν‚€λ§ˆ 예제 μΆ”κ°€λ₯Ό ν†΅ν•œ DX ν–₯상
**Learning:** λ°±μ—”λ“œ μ „μš© FastAPI ν”„λ‘œμ νŠΈμ—μ„œλŠ” Pydantic μŠ€ν‚€λ§ˆμ— `json_schema_extra={"example": ...}`λ₯Ό μΆ”κ°€ν•˜μ—¬ OpenAPI λ¬Έμ„œ ν’ˆμ§ˆμ„ λ†’μ΄λŠ” 것이 μ€‘μš”ν•œ μ‚¬μš©μž κ²½ν—˜(DX) ν–₯상 μš”μ†Œμž„μ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.
**Action:** ν–₯ν›„ Pydantic λͺ¨λΈ μž‘μ„± μ‹œ API μ†ŒλΉ„μžμ˜ 이해λ₯Ό 돕기 μœ„ν•΄ ν•„λ“œμ— ꡬ체적인 예제 값을 기본적으둜 μΆ”κ°€ν•˜λ„λ‘ ν•©λ‹ˆλ‹€.
🧰 Tools
πŸͺ› markdownlint-cli2 (0.23.1)

[warning] 4-4: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above

(MD022, blanks-around-headings)


[warning] 4-4: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.jules/palette.md around lines 4 - 6, Update the new β€œ2024-07-29 - OpenAPI
μŠ€ν‚€λ§ˆ 예제 μΆ”κ°€λ₯Ό ν†΅ν•œ DX ν–₯상” heading in the palette documentation to have one blank line
before and after it, separating it from adjacent paragraphs and satisfying
MD022.

Source: Linters/SAST tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant