refactor(naming): use semantic publication and batch identifiers - #1024
Draft
seonghobae wants to merge 6 commits into
Draft
seonghobae wants to merge 6 commits into
seonghobae wants to merge 6 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adopt protected main without rewriting branch history. Against merge base 8839081, the NIM naming delta is confined to contextual_orchestrator/nim_evidence.py and tests/test_nim_evidence_naming_contract.py, while protected main does not modify either path. This merge tree preserves both exact snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This is the canonical naming repair for two private contextual-orchestrator boundaries: NIM benchmark-evidence atomic publication and the synchronous adapters over injected async pg-llm-batch clients. The branch has been reconciled against the current
main@464da4715b495b5eaaa593eba3796e2d976ee0c9; external/public contracts remain unchanged.TDD lineage
NIM evidence publication
6ea1f728e267ce9983a1a599c34c8989cae0a52erequires_publication_residue_paths(final_directory, residue_kind)and proves the old_residueauthority must disappear.b2ccbd663e6c624d1b0773bf41409ced0f7f840eapplies the semantic rename through all private callers and co-located publication-state identifiers.Old → new vocabulary includes
_residue→_publication_residue_paths,final→final_directory,kind→residue_kind,prefix→residue_prefix,flags→open_flags,descriptor→lock_descriptor,staging→staging_directory,backup/backups→backup_directory/backup_paths, and artifactname/payload→artifact_name/artifact_payload.pg-llm-batch sync/async adapter
21d1c18d91497730cfc887afa353084359f92322adds an AST/source contract for the two pg-llm-batch adapter classes. The then-current production file still exposed two private_run(coro)methods and sixself._run(...)callers, so the regression corresponds to the exact current defect.36996df189bd40e3d7223a710d83edc7c70c8ebarenames both private bridges to_run_async_client_operation(async_operation)and propagates all six submit/poll/retrieve callers.0fbb183a3151a2674a40aa8ae0d58eb74defbc97restores two pre-existing docstring literals that were accidentally escaped while replacing the large source file. Comparing the RED head to this exact head leaves only the intended 10 additions/10 deletions inbatch_routing.py.Compatibility and persistence
No public Python call shape, OpenAI-compatible JSONL field, pg-llm-batch client method, serialized NIM evidence schema, artifact filename, provenance field, database object, migration, FK, index, ORM mapping, UPSERT path, partitioning, lock model, or read/write topology changes.
id,status,body,data, and similar fields required by upstream/OpenAI-compatible payloads remain at their protocol/adapter boundary rather than being mechanically renamed.Verification boundary
Current exact head:
0fbb183a3151a2674a40aa8ae0d58eb74defbc97. Keep Draft until fresh exact-head hosted checks are terminal-success, current review findings/threads are resolved, and a qualifying independent non-author approval applies to the unchanged last push. Predecessor/base/model-only evidence is not merge evidence; do not self-approve, force-push, or bypass protection.