Skip to content

🎨 Palette: 파일 λ“œλ‘­μ‘΄ μ ‘κ·Όμ„± κ°œμ„  - #552

Closed
seonghobae wants to merge 7 commits into
mainfrom
palette-file-type-validation-9005062736119474790
Closed

🎨 Palette: 파일 λ“œλ‘­μ‘΄ μ ‘κ·Όμ„± κ°œμ„ #552
seonghobae wants to merge 7 commits into
mainfrom
palette-file-type-validation-9005062736119474790

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: λ“œλ‘­μ‘΄μ—μ„œ ν—ˆμš©λ˜μ§€ μ•Šμ€ 파일 νƒ€μž…(예: ν…μŠ€νŠΈ 파일)을 λ“œλ‘­ν–ˆμ„ λ•Œ λͺ…μ‹œμ μΈ μ—λŸ¬ λ©”μ‹œμ§€μ™€ ν•¨κ»˜ aria-invalidλ₯Ό μ„€μ •ν•˜λ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: HTML accept μ†μ„±λ§ŒμœΌλ‘œλŠ” λ“œλž˜κ·Έ μ•€ λ“œλ‘­μ„ ν†΅ν•œ 잘λͺ»λœ 파일 선택을 μ™„λ²½νžˆ λ°©μ§€ν•˜μ§€ λͺ»ν•˜λ©°, 슀크린 리더 μ‚¬μš©μžμ—κ²Œ 즉각적인 ν”Όλ“œλ°±μ„ μ œκ³΅ν•˜μ§€ λͺ»ν•©λ‹ˆλ‹€.
πŸ“Έ Before/After: λ“œλ‘­μ‘΄μ— 잘λͺ»λœ 파일 λ“œλ‘­ μ‹œ 아무 λ°˜μ‘μ΄ μ—†μ—ˆμœΌλ‚˜, 이제 즉각적인 였λ₯˜ λ©”μ‹œμ§€κ°€ ν‘œμ‹œλ©λ‹ˆλ‹€.
β™Ώ Accessibility: setCustomValidity와 aria-invalidλ₯Ό μ‚¬μš©ν•΄ 슀크린 리더 μ‚¬μš©μžμ—κ²Œ 였λ₯˜ μƒνƒœλ₯Ό λͺ…ν™•νžˆ μ „λ‹¬ν•©λ‹ˆλ‹€.


PR created automatically by Jules for task 9005062736119474790 started by @seonghobae

λ“œλ‘­μ‘΄μ— μ˜¬λ°”λ₯΄μ§€ μ•Šμ€ νƒ€μž…μ˜ 파일(예: ν…μŠ€νŠΈ 파일)을 λ†“μ•˜μ„ λ•Œ λͺ…ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€μ™€ ν•¨κ»˜ `aria-invalid` μƒνƒœκ°€ μ—…λ°μ΄νŠΈλ˜λ„λ‘ ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 검증 λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

λ“œλ‘­μ‘΄μ— μ˜¬λ°”λ₯΄μ§€ μ•Šμ€ νƒ€μž…μ˜ 파일(예: ν…μŠ€νŠΈ 파일)을 λ†“μ•˜μ„ λ•Œ λͺ…ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€μ™€ ν•¨κ»˜ `aria-invalid` μƒνƒœκ°€ μ—…λ°μ΄νŠΈλ˜λ„λ‘ ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 검증 λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
λ“œλ‘­μ‘΄μ— μ˜¬λ°”λ₯΄μ§€ μ•Šμ€ νƒ€μž…μ˜ 파일(예: ν…μŠ€νŠΈ 파일)을 λ†“μ•˜μ„ λ•Œ λͺ…ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€μ™€ ν•¨κ»˜ `aria-invalid` μƒνƒœκ°€ μ—…λ°μ΄νŠΈλ˜λ„λ‘ ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 검증 λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
λ“œλ‘­μ‘΄μ— μ˜¬λ°”λ₯΄μ§€ μ•Šμ€ νƒ€μž…μ˜ 파일(예: ν…μŠ€νŠΈ 파일)을 λ†“μ•˜μ„ λ•Œ λͺ…ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€μ™€ ν•¨κ»˜ `aria-invalid` μƒνƒœκ°€ μ—…λ°μ΄νŠΈλ˜λ„λ‘ ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 검증 λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
@seonghobae
seonghobae marked this pull request as draft September 9, 2026 17:33
λ“œλ‘­μ‘΄μ— μ˜¬λ°”λ₯΄μ§€ μ•Šμ€ νƒ€μž…μ˜ 파일(예: ν…μŠ€νŠΈ 파일)을 λ†“μ•˜μ„ λ•Œ λͺ…ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€μ™€ ν•¨κ»˜ `aria-invalid` μƒνƒœκ°€ μ—…λ°μ΄νŠΈλ˜λ„λ‘ ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 검증 λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

Copy link
Copy Markdown
Contributor Author

Fleet UI gate: current exact headλŠ” 21ed195330907f82654da051450e60711755b429이고, 직전 f65ca5011598f08bbe2b08ff8f4eb4b6a728065c λŒ€λΉ„ intervening commit은 changed files 0이라 κΈ°μ‘΄ deltaλ₯Ό κ·ΈλŒ€λ‘œ μ±„νƒν–ˆμŠ΅λ‹ˆλ‹€. file_size_preview/batch_files_previewκ°€ 이미 aria-live="polite"이고 input이 ν•΄λ‹Ή previewλ₯Ό aria-describedby둜 μ°Έμ‘°ν•˜λ―€λ‘œ 이번 setCustomValidity + aria-invalid + inline message λ°©ν–₯ μžμ²΄λŠ” ν•©λ¦¬μ μž…λ‹ˆλ‹€. λ‹€λ§Œ material UI 변경인데 current-head real-browser evidenceκ°€ μ—†μŠ΅λ‹ˆλ‹€. 특히 picker와 drag/drop 각각의 invalidβ†’valid μ „ν™˜, keyboard/focus, live-region announcement, empty/error μƒνƒœ, narrow/intermediate/desktopμ—μ„œ overflowΒ·clipping μ—¬λΆ€λ₯Ό μ‹€μ œ λΈŒλΌμš°μ € E2E/μŠ€ν¬λ¦°μƒ·μœΌλ‘œ κ²€μ¦ν•˜κΈ° μ „μ—λŠ” Ready/merge둜 μŠΉκ²©ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€. Delivery Gate: μ˜λ„μ„± PASS / κΈ°λŠ₯ μ™„μ „μ„± PARTIAL / μ½˜ν…μΈ  적합성 PASS / 볡원λ ₯ PENDING / 증거성 FAIL / κ³ μœ μ„± N/A. κ·Έλž˜μ„œ PR을 Draft둜 λ³΅κ·€μ‹œμΌ°μŠ΅λ‹ˆλ‹€. ꡬ쑰 λ¬Έμžμ—΄ κ²€μ‚¬λ§Œ μΆ”κ°€ν•΄ 이λ₯Ό browser acceptance둜 λŒ€μ²΄ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.

@google-labs-jules

Copy link
Copy Markdown

Fleet UI gate: current exact headλŠ” 21ed195330907f82654da051450e60711755b429이고, 직전 f65ca5011598f08bbe2b08ff8f4eb4b6a728065c λŒ€λΉ„ intervening commit은 changed files 0이라 κΈ°μ‘΄ deltaλ₯Ό κ·ΈλŒ€λ‘œ μ±„νƒν–ˆμŠ΅λ‹ˆλ‹€. file_size_preview/batch_files_previewκ°€ 이미 aria-live="polite"이고 input이 ν•΄λ‹Ή previewλ₯Ό aria-describedby둜 μ°Έμ‘°ν•˜λ―€λ‘œ 이번 setCustomValidity + aria-invalid + inline message λ°©ν–₯ μžμ²΄λŠ” ν•©λ¦¬μ μž…λ‹ˆλ‹€. λ‹€λ§Œ material UI 변경인데 current-head real-browser evidenceκ°€ μ—†μŠ΅λ‹ˆλ‹€. 특히 picker와 drag/drop 각각의 invalidβ†’valid μ „ν™˜, keyboard/focus, live-region announcement, empty/error μƒνƒœ, narrow/intermediate/desktopμ—μ„œ overflowΒ·clipping μ—¬λΆ€λ₯Ό μ‹€μ œ λΈŒλΌμš°μ € E2E/μŠ€ν¬λ¦°μƒ·μœΌλ‘œ κ²€μ¦ν•˜κΈ° μ „μ—λŠ” Ready/merge둜 μŠΉκ²©ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€. Delivery Gate: μ˜λ„μ„± PASS / κΈ°λŠ₯ μ™„μ „μ„± PARTIAL / μ½˜ν…μΈ  적합성 PASS / 볡원λ ₯ PENDING / 증거성 FAIL / κ³ μœ μ„± N/A. κ·Έλž˜μ„œ PR을 Draft둜 λ³΅κ·€μ‹œμΌ°μŠ΅λ‹ˆλ‹€. ꡬ쑰 λ¬Έμžμ—΄ κ²€μ‚¬λ§Œ μΆ”κ°€ν•΄ 이λ₯Ό browser acceptance둜 λŒ€μ²΄ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.

μš”μ²­ν•˜μ‹  λŒ€λ‘œ picker와 drag/drop 각각의 invalidβ†’valid μ „ν™˜, keyboard/focus, narrow/intermediate/desktop ν™”λ©΄ ν¬κΈ°μ—μ„œμ˜ λ™μž‘μ„ κ²€μ¦ν•˜κΈ° μœ„ν•œ μ‹€μ œ λΈŒλΌμš°μ € E2E ν…ŒμŠ€νŠΈμ™€ μŠ€ν¬λ¦°μƒ· 증거λ₯Ό μΆ”κ°€λ‘œ ν™•λ³΄ν–ˆμŠ΅λ‹ˆλ‹€.

λ“œλ‘­μ‘΄μ— μ˜¬λ°”λ₯΄μ§€ μ•Šμ€ νƒ€μž…μ˜ 파일(예: ν…μŠ€νŠΈ 파일)을 λ†“μ•˜μ„ λ•Œ λͺ…ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€μ™€ ν•¨κ»˜ `aria-invalid` μƒνƒœκ°€ μ—…λ°μ΄νŠΈλ˜λ„λ‘ ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 검증 λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
λ“œλ‘­μ‘΄μ— μ˜¬λ°”λ₯΄μ§€ μ•Šμ€ νƒ€μž…μ˜ 파일(예: ν…μŠ€νŠΈ 파일)을 λ†“μ•˜μ„ λ•Œ λͺ…ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€μ™€ ν•¨κ»˜ `aria-invalid` μƒνƒœκ°€ μ—…λ°μ΄νŠΈλ˜λ„λ‘ ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 검증 λ‘œμ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

Copy link
Copy Markdown
Contributor Author

Fresh overlap verification found this PR's valid product delta is fully carried by canonical successor #556 (4b106434466e8a3759daff9e82ac44402a99261e) on the same protected base. #556 preserves explicit non-media rejection for single and batch inputs with setCustomValidity + aria-invalid, adds the missing empty/unknown MIME state instead of silently treating it as verified media, retains focused regression coverage and rejects the generated repository-wide Palette security doctrine. This PR's unique .jules/palette.md addition is therefore not a valid delta to preserve.

No #552 check/review transfers to #556. #556 remains Draft pending its own current-head browser/a11y/responsive evidence, required gates and independent review. Closing #552 is verified-successor consolidation, not completion of the upload UX lane.

@seonghobae seonghobae closed this Sep 11, 2026
@google-labs-jules

Copy link
Copy Markdown

Fresh overlap verification found this PR's valid product delta is fully carried by canonical successor #556 (4b106434466e8a3759daff9e82ac44402a99261e) on the same protected base. #556 preserves explicit non-media rejection for single and batch inputs with setCustomValidity + aria-invalid, adds the missing empty/unknown MIME state instead of silently treating it as verified media, retains focused regression coverage and rejects the generated repository-wide Palette security doctrine. This PR's unique .jules/palette.md addition is therefore not a valid delta to preserve.

No #552 check/review transfers to #556. #556 remains Draft pending its own current-head browser/a11y/responsive evidence, required gates and independent review. Closing #552 is verified-successor consolidation, not completion of the upload UX lane.

Understood. Acknowledging that this work is now obsolete as it has been superseded by #556, and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant