chore(deps): bump rust-toolchain from 1.98.0 to 1.98.1 - #494
chore(deps): bump rust-toolchain from 1.98.0 to 1.98.1#494dependabot[bot] wants to merge 9 commits into
Conversation
Bumps [rust-toolchain](https://github.com/rust-lang/rust) from 1.98.0 to 1.98.1. - [Release notes](https://github.com/rust-lang/rust/releases) - [Changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md) - [Commits](rust-lang/rust@1.98.0...1.98.1) --- updated-dependencies: - dependency-name: rust-toolchain dependency-version: 1.98.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.
Findings
1. HIGH Current-head GitHub Checks - Fix failed required checks before approval
- Problem: Failed same-head checks remain for
c8acfcfe68fd1f65b62d9f345ad5920adbe3515f. - Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
- Fix: Read and fix the failed check logs below, then rerun the current-head checks.
- Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.
Failed checks:
- CodeQL PR/CodeQL compatibility analysis (actions): FAILURE (https://github.com/ContextualWisdomLab/TEPP/actions/runs/34303731136/job/102316063867)
- CodeQL PR/CodeQL compatibility analysis (python): FAILURE (https://github.com/ContextualWisdomLab/TEPP/actions/runs/34303731136/job/102316063824)
- CodeQL compatibility analysis (actions) check run: failure (https://github.com/ContextualWisdomLab/TEPP/actions/runs/34303731136/job/102316063867)
- CodeQL compatibility analysis (python) check run: failure (https://github.com/ContextualWisdomLab/TEPP/actions/runs/34303731136/job/102316063824)
- Repository contracts and Python branch coverage check run: failure (https://github.com/ContextualWisdomLab/TEPP/actions/runs/34303730856/job/102315940451)
- Required Noema Review/noema-review: FAILURE (https://github.com/ContextualWisdomLab/TEPP/actions/runs/34303730021/job/102316137265)
- Rust Foundation CI/Repository contracts and Python branch coverage: FAILURE (https://github.com/ContextualWisdomLab/TEPP/actions/runs/34303730856/job/102315940451)
- noema-review check run: failure (https://github.com/ContextualWisdomLab/TEPP/actions/runs/34303730021/job/102316137265)
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Repository file: rust-toolchain.toml"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Repository file: rust-toolchain.toml"]
R1 --> V1["required checks"]
OpenCode Review Overview
|
|
현재 exact head 이 전환은 source/history를 버리거나 gate를 약화하는 조치가 아닙니다. 기존 Rust 1.98.1 toolchain/CI/scheduler repair delta는 그대로 보존합니다. 다음 owner-correct repair는 (1) 1.98.1은 build-reference pin, |
|
CodeQL RED도 current-head job 단위로 분류했습니다. Run 따라서 이 PR에서 CodeQL requirement를 제거하거나 우회하지 않습니다. Canonical |
|
Fresh foundation coordination from the TEPP Validation Evidence lane: exact The code-current documentation finding in this PR body is still real: |
|
@coderabbitai review |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '== checked-out revision =='
git rev-parse HEAD
git status --short
echo '== candidate tracked files =='
git ls-files | rg '(^|/)(ARCHITECTURE\.md|Cargo\.toml|rust-toolchain\.toml|Dockerfile|README.*|CHANGELOG.*|.*\.(md|mdx|rst|yml|yaml|json|toml))$' || true
echo '== Rust 1.98 version references in tracked text/config files =='
git grep -n -I -E '1\.98\.[01]|rust-version|rust-toolchain|toolchain install|rustup.*install' -- \
':**.md' ':**.mdx' ':**.rst' ':**.toml' ':**.yml' ':**.yaml' ':**.json' \
':Dockerfile' ':**/Dockerfile' ':Cargo.toml' ':**/Cargo.toml' ':rust-toolchain.toml' ':**/rust-toolchain.toml' || true
echo '== architecture and manifest context =='
for f in ARCHITECTURE.md Cargo.toml rust-toolchain.toml Dockerfile; do
if [ -f "$f" ]; then
echo "--- $f ---"
rg -n -C 3 -I -E '1\.98\.[01]|rust-version|toolchain|Rust' "$f" || true
fi
done
echo '== changed files at requested commit relative to first parent =='
git diff-tree --no-commit-id --name-status -r ea2e5ec612b20a05f6a89bb2fc0e896ed1bc4f45^ ea2e5ec612b20a05f6a89bb2fc0e896ed1bc4f45Length of output: 19312 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '== all tracked 1.98 references with context =='
git grep -n -I -C 3 -E '1\.98\.[01]' -- ':!Cargo.lock' || true
echo '== root manifest and toolchain files =='
cat -n Cargo.toml | sed -n '116,134p'
cat -n rust-toolchain.toml
cat -n ARCHITECTURE.md | sed -n '158,176p'
cat -n docs/research/rust-quality-tooling.md | sed -n '1,105p'
cat -n docs/adr/0007-rust-workspace-quality-gates.md | sed -n '1,85p'
echo '== CI/verifier toolchain and schedule context =='
rg -n -C 5 -I 'rustup toolchain install 1\.98\.1|rust-toolchain\.toml|schedule:|workflow_dispatch|cwl-org-commercial-entrypoint' \
.github/workflows/ci.yml .github/workflows/hourly-nim-product-development.yml
echo '== Python contract references =='
git grep -n -I -C 3 -E 'rust-version|1\.98\.[01]|rust-toolchain' -- '*.py' || true
echo '== cumulative requested-head diff from merge base with main =='
base="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main)"
printf 'base=%s\n' "$base"
git diff --stat "$base"..HEAD
git diff --find-renames --unified=40 "$base"..HEAD -- \
rust-toolchain.toml Cargo.toml ARCHITECTURE.md docs/research/rust-quality-tooling.md \
.github/workflows/ci.yml .github/workflows/hourly-nim-product-development.yml \
':**.py'Length of output: 73396
다른 현재 문서와 구성은 이 두 버전을 올바르게 구분합니다.
로컬 스케줄 복원, provider-routing 변경, CodeQL·coverage·security gate 완화, 또는 검증되지 않은 Docker image 변경은 필요하지 않습니다. ✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughRust 툴체인을 1.98.1로 갱신했습니다. 모든 관련 CI 작업과 시간별 제품 품질 게이트가 동일한 버전을 설치합니다. 테스트는 고정 버전과 워크플로 계약을 검증하며, 문서는 변경 근거와 검증 기준을 갱신합니다. ChangesRust 툴체인 정렬
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR only bumps the pinned Rust toolchain from 1.98.1 for CI, coverage, database, and hourly product workflows, keeping the 1.98.0 MSRV unchanged, and updates tests/docs to match. No functional or data-integrity risk was identified in the changed files. The PR remains in draft due to unrelated control-plane/CodeQL receipt issues and pending documentation/approval steps called out in the PR description, not because of a defect found in this review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Current-head independent review has now converged on the same single repository-local code-current defect: CodeRabbit reviewed I also re-ran only the failed jobs of CodeQL PR |
|
Fresh central-owner handoff: The remaining TEPP-owned #494 source repair is unchanged: correct only the stale |
|
Fresh prerequisite sweep on exact
Keep #494 Draft until the one-line architecture drift is repaired, the central owner yields a terminal authenticated exact-head CodeQL receipt, exact-head checks are reacquired after source mutation, and a qualifying current-head approval exists. No image-tag/digest substitution is authorized without verified immutable 1.98.1 Bookworm evidence. |
1 participant
Rust 1.98.1 compatibility repair
Rust 1.98.1 was published by the Rust Release Team on 2026-09-03 to fix a rustc vtable-generation miscompilation present in 1.98.0. This Draft keeps the Dependabot patch update and repairs verified repository-level consequences without changing the declared MSRV or weakening CI/security policy.
Current exact head is
97e10a646ca43babcf06c6e36d5bd8f6b1c3b16aon protectedmain@a243f18da4a4ca8a8d068c39922537f1f8ed6ad0.Preserved RED → repair lineage
Original Dependabot head
c8acfcfe68fd1f65b62d9f345ad5920adbe3515fchanged onlyrust-toolchain.tomlfrom 1.98.0 to 1.98.1. Subsequent forward commits synchronized repository contract tests, stable CI lanes, the commercial verifier and current schedule-admission expectations while preservingCargo.toml rust-version = "1.98.0"as MSRV and keeping repository-local scheduling removed.Official compiler source: Rust Release Team. (2026, September 3). Announcing Rust 1.98.1. Rust Blog. https://blog.rust-lang.org/2026/09/03/Rust-1.98.1/
Remaining code-current source finding
ARCHITECTURE.mdstill states: “Stable Rust 1.98.0 is the compile, lint, test, and line-coverage reference.” The branch's root toolchain/CI/verifier build reference is 1.98.1, so that sentence still requires a one-line repair before this PR is code-current.An attempted narrow edit at
54ed1dcc6d59cf696763a999a5553ba423ddc372was rejected by exact diff review because it unintentionally omitted three existing architecture-table rows while changing the intended sentence. The omission was immediately repaired by ordinary forward commit97e10a646ca43babcf06c6e36d5bd8f6b1c3b16a. Comparingea2e5ec...to97e10a...yields no file delta, so the branch is source-equivalent to the last verified source head; the stale architecture sentence therefore remains unresolved rather than being claimed fixed. No force update or destructive rebase was used.Do not globally replace every 1.98.0 occurrence.
Cargo.toml rust-version = "1.98.0"remains the MSRV and historical ADR/CHANGELOG evidence remains historical truth.Dockerfilestill uses the verified immutable 1.98.0 Bookworm image; do not substitute an unverified 1.98.1 tag or digest.The repository-local commercial entrypoint also still contains legacy provider-key/bootstrap behavior owned by #492 /
.github#2038/ contextual-orchestrator #1023/#1083. This compiler patch must not copy or redesign that unpublished orchestration contract.Exact-head verification
Fresh exact-head workflows for
97e10a646ca43babcf06c6e36d5bd8f6b1c3b16aare terminal:34564877786: GREEN.34564877774: GREEN.34564877776: GREEN.34564877798: GREEN.34564877779: RED in the delegated compatibility receipt path.CodeQL language detection job
103154836880and fresh current-head dispatch job103157070548are GREEN. Compatibility jobs103155462817(python) and103155462854(actions) both read the current-head dispatch verdict successfully and then fail atRelease runner or enforce current-head CodeQL verdict. This is the same delegated producer/handler settlement class already owned centrally; it is not evidence of a Rust 1.98.1 compiler/source regression and is not a reason to weaken or bypass CodeQL.The canonical central owner remains
.github#1929with combined successor.github#2040. On.github#2040@6706c231ab06a3c91c43fdb5b989cfcd79fff593, Security Scan, SAST Semgrep, Python Security, and Agent Review Runtime Quality are terminal GREEN while CodeQL PR34251822255is terminal RED; attempt 7 fails in the central actions/python verdict path and current-head dispatch. TEPP must not synthesize a receipt, loop no-op consumer pushes, or fork that control-plane repair locally.Review / merge bar
The only formal review remains the historical OpenCode
CHANGES_REQUESTEDsubmission on original headc8acfcfe...; it is not a qualifying current-head approval. There are no unresolved inline review threads. This PR remains Draft and unmerged.Before Ready/merge: repair only the stale
ARCHITECTURE.mdbuild-reference sentence without changing MSRV/history/Docker provenance; acquire a terminal GREEN CodeQL receipt through the canonical owner path; and obtain a qualifying independent current-head approval. No force push, destructive rebase, self-approval, fabricated receipt, unverified image substitution, gate weakening, no-op rerun loop, or routine admin bypass.