feat(analysis): bind TDT/CHRONOS composition to an analysis-run profile by seonghobae · Pull Request #364 · ContextualWisdomLab/TEPP

seonghobae · 2026-08-31T09:56:43Z

Summary

GAP-007 remaining operator-visible slice: bind the already-merged event_core TDT/CHRONOS composition (compose_event_intelligence, #269 on protected main) to an analysis_engine analysis-run output profile so operators can request the composed workflow.

New profile tdt_chronos_workflow_v1 / schema tepp.tdt_chronos_workflow.v1 (ADR 0030; 0026–0029 remain on other live PRs).
Cutoff-filters mentions by available_time against the request knowledge_cutoff; drops links that cite an excluded mention; keeps first-story/track streams aligned.
Digest-bound terminal result. Envelope layer stays tdt_detection; CHRONOS hypotheses stay chronos_prediction. Inference status is composed_workflow_not_instance_or_transition.
Invokes refuse_composition_as_instance and refuse_composition_as_transition. Does not invent an extractor, persist rows, or promote an instance/transition.

This is not implemented-main. Exact-head Checks on this head only. Predecessor-head evidence does not transfer.

Does not duplicate:

GAP-003A feat(analysis): bind validation runs to scientific acceptance evidence #356 engine-library / feat(api): carry scientific acceptance only on terminal results #358 DTO / feat(api): serve scientific acceptance only on loopback status GET #359 HTTP GET / feat(api): record scientific acceptance via loopback lifecycle POST #360 lifecycle POST / feat(api): cancel accepted and running analysis runs on loopback #361 cancel / feat(api): drive scientific acceptance via loopback CLI #362 CLI
GAP-003B persistence feat(persistence): persist idempotent analysis runs #287
GAP-009 Leiden feat(network): replace union-find stand-in with Leiden consensus #351
Driver p.16 std-family feat(longitudinal): consolidate lagged correlation and discreteDRIFTstd #310+
interval-artifact fix(event): bind complete interval artifact authority #293

Test plan

cargo test -p analysis_engine
cargo clippy -p analysis_engine --all-targets -- -D warnings
RUSTDOCFLAGS="-D warnings" cargo doc -p analysis_engine --no-deps
Exact-head Required Checks on this SHA
Two independent (non-author, non-bot) APPROVE reviews

Merge bar

Ruleset 18156473: two independent approvals + exact-head Checks. Do not self-approve. Do not --admin merge.

Operators can request the existing event_core workflow as tdt_chronos_workflow_v1. Mentions unavailable at the request cutoff are excluded; the digest-bound tepp.tdt_chronos_workflow.v1 artifact records detection versus prediction layers and refuses instance/transition promotion. Not a new extractor, not persistence, and not implemented-main.

coderabbitai · 2026-08-31T09:56:52Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 8 potential issues.

devin-ai-integration · 2026-08-31T09:59:27Z

🔍 Exact-head coverage remains pending

Repository rules require 100% production line and branch coverage. The PR description leaves exact-head checks pending for the new validation and error paths.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T09:59:29Z

+        config: input.config,
+        segmentation: input.segmentation,
+        mentions,
+        links,
+        first_story_labels,
+        track_assignments,
+        schema_slot_assignments: input.schema_slot_assignments,
+        occurrence_forecasts: input.occurrence_forecasts,


🔴 Late workflow evidence survives cutoff

When a run uses an earlier cutoff, admit_mentions_at_cutoff filters mentions but retains segmentation, schema slots, and forecasts unchanged. Results can include future-derived evidence.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T09:59:30Z

+    let links: Vec<_> = input
+        .links
+        .into_iter()
+        .filter(|link| eligible_ids.contains(&link.left()) && eligible_ids.contains(&link.right()))
+        .collect();


🟡 Foreign links are silently accepted

When a link references a mention absent from the input, filter drops it as cutoff-excluded. Malformed workflows can succeed with understated links.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T09:59:31Z

+            run_id: accepted.run_id.clone(),
+            snapshot_id: snapshot_id.to_owned(),
+            knowledge_cutoff: knowledge_cutoff.to_rfc3339(),
+            workflow_version: composition.config_version(),


🟡 Workflow configuration escapes the digest

Replaying one accepted run with changed thresholds makes from_composition record only version 1. Different decision configurations can produce indistinguishable artifacts and digests.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T09:59:32Z

+    pub fn to_json(&self) -> Result<String, AnalysisEngineError> {
+        self.validate()?;
+        let payload =
+            serde_json::to_string(self).map_err(|_| AnalysisEngineError::SerializationFailure)?;
+        Ok(payload)
+    }


🔍 Output limit is one-sided

to_json omits the advertised 256 KiB check. Current bounded fields stay small, but future variable-sized schema fields can bypass the output contract.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T09:59:33Z

+    let _ = refuse_composition_as_instance(&composition);
+    let _ = refuse_composition_as_transition(&composition);


📝 Info: Refusal calls are declarative

Both refusal APIs always return fixed errors without side effects. Ignoring their results preserves the boundary, but the calls add no runtime validation.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T09:59:34Z

+    if input.first_story_labels.len() != input.mentions.len()
+        || input.track_assignments.len() != input.mentions.len()
+    {
+        return Err(AnalysisEngineError::Event(EventError::InvalidWirePayload));
+    }
+    let mut mentions = Vec::new();
+    let mut first_story_labels = Vec::new();
+    let mut track_assignments = Vec::new();
+    let mut excluded_after_cutoff_count = 0_u64;
+    for ((mention, first_story), track) in input
+        .mentions
+        .into_iter()
+        .zip(input.first_story_labels)
+        .zip(input.track_assignments)
+    {
+        if mention.clocks().available_time().instant() <= knowledge_cutoff.instant() {
+            mentions.push(mention);
+            first_story_labels.push(first_story);
+            track_assignments.push(track);


📝 Info: Indexed streams remain aligned

admit_mentions_at_cutoff checks equal lengths before zipping. Each excluded mention removes its corresponding label and track, then composition verifies track identities.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T09:59:35Z

+    let admitted = admit_mentions_at_cutoff(input, knowledge_cutoff)?;
+    let composition = compose_event_intelligence(


🟨 Untrusted workflow inputs lack resource bounds

execute_event_intelligence_run accepts unlimited collections before quadratic composition checks. An oversized request can exhaust service CPU and memory.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration

Devin Review found 4 new potential issues.

devin-ai-integration · 2026-08-31T17:36:14Z

+    let summary = AnalysisResultSummary::new(
+        "tdt_chronos_workflow",
+        artifact.mention_count,
+        statistic_count,
+        EVENT_INTELLIGENCE_INFERENCE_STATUS,
+    )
+    .expect("bounded event-intelligence summary constants are valid");


🔴 Oversized runs panic during completion

Over one billion evidence items or combined outputs makes AnalysisResultSummary::new fail. expect then crashes the executor instead of rejecting the run.

Suggested change

let summary = AnalysisResultSummary::new(

"tdt_chronos_workflow",

artifact.mention_count,

statistic_count,

EVENT_INTELLIGENCE_INFERENCE_STATUS,

)

.expect("bounded event-intelligence summary constants are valid");

let summary = AnalysisResultSummary::new(

"tdt_chronos_workflow",

artifact.mention_count,

statistic_count,

EVENT_INTELLIGENCE_INFERENCE_STATUS,

)?;

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T17:36:16Z

+    let links: Vec<_> = input
+        .links
+        .into_iter()
+        .filter(|link| eligible_ids.contains(&link.left()) & eligible_ids.contains(&link.right()))


📝 Info: Link filtering remains equivalent

Bitwise & evaluates both pure contains calls, but returns the same Boolean result as &&. No links change eligibility.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T17:36:17Z

+    )
+    .expect("validated composition produces a valid bounded artifact");


📝 Info: Artifact assertion remains unreachable

Successful composition guarantees every validation invariant used by from_composition. Its length conversions also fit u64 on supported platforms.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T17:36:18Z

+#[test]
+fn execution_refuses_invalid_completion_time() {
+    let fixture = KnownTruthFixture::build();
+    let request = request();
+    let accepted = accepted(&request);
+    assert_eq!(
+        execute_event_intelligence_run(
+            &request,
+            &accepted,
+            "snapshot-event-intelligence",
+            cutoff(),
+            fixture.input(),
+            "invalid",
+        ),
+        Err(AnalysisEngineError::Api(
+            tepp_api::ApiError::InvalidWirePayload
+        ))
+    );


📝 Info: Completion errors still propagate

An invalid completion timestamp reaches terminal-result validation and returns its contract error. The earlier assertions do not mask this failure.

Was this helpful? React with 👍 or 👎 to provide feedback.

Resolve the CHANGELOG.md append conflict by keeping both entries. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

…elligence_run The repository docstring contract scans attribute lines only when they start with '#[', so a multi-line #[expect(...)] between the '///' block and 'pub fn' hid the documentation. Move the attribute above the doc comment; attribute order has no semantic effect. #502 fixes the checker. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

seonghobae · 2026-09-14T05:29:23Z

Restack on protected main (`a243f18`) + docstring-contract repair

Non-force merge of origin/main (merge commit b4b0efb1); the only conflict was the CHANGELOG.md append, both entries kept. ADR 0030 already carries an admitted maturity value (active-PR).
scripts/check_docstrings.py failed on this branch before the restack (event_intelligence_artifact.rs:239: public item lacks /// rustdoc): the function is documented, but a multi-line #[expect(clippy::missing_panics_doc, …)] between the /// block and pub fn hides it from the checker. Moved the attribute above the doc comment (no semantic change). The checker itself is fixed in fix(quality): keep rustdoc attached across multi-line attributes #502.

Local evidence on the pushed head (toolchain 1.98.0): cargo test -p analysis_engine 40 passed / 0 failed, clippy -D warnings clean, cargo fmt --all --check clean, documentation/workspace/docstring contracts PASS, git diff --check clean.

🤖 Generated with Claude Code

devin-ai-integration Bot reviewed Aug 31, 2026

View reviewed changes

test(analysis): close event intelligence coverage gaps

8415d34

devin-ai-integration Bot reviewed Aug 31, 2026

View reviewed changes

This was referenced Aug 31, 2026

feat(analysis): bind joint posterior Laplace draws to an analysis-run profile #408

Draft

feat(analysis): bind Pareto candidate-K selection to an analysis-run profile #409

Draft

feat(analysis): compose fitted candidate-K selection with topic lineage #412

Draft

seonghobae marked this pull request as draft September 1, 2026 16:37

seonghobae added enhancement New feature or request type: feature priority: medium labels Sep 7, 2026 — with ChatGPT Codex Connector

seonghobae and others added 2 commits September 14, 2026 14:27

Merge origin/main into feat/event-intelligence-analysis-run-gap-007

b4b0efb

Resolve the CHANGELOG.md append conflict by keeping both entries. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

		let _ = refuse_composition_as_instance(&composition);
		let _ = refuse_composition_as_transition(&composition);

		let admitted = admit_mentions_at_cutoff(input, knowledge_cutoff)?;
		let composition = compose_event_intelligence(

		)
		.expect("validated composition produces a valid bounded artifact");

Uh oh!

Conversation

seonghobae commented Aug 31, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Merge bar

Uh oh!

coderabbitai Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Draft PR not reviewed

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

seonghobae commented Sep 14, 2026

Restack on protected main (a243f18) + docstring-contract repair

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Aug 31, 2026 •

edited by devin-ai-integration Bot

Loading

coderabbitai Bot commented Aug 31, 2026 •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading

devin-ai-integration Bot Aug 31, 2026 •

edited

Loading

devin-ai-integration Bot Aug 31, 2026 •

edited

Loading

devin-ai-integration Bot Aug 31, 2026 •

edited

Loading

devin-ai-integration Bot Aug 31, 2026 •

edited

Loading

devin-ai-integration Bot Aug 31, 2026 •

edited

Loading

devin-ai-integration Bot Aug 31, 2026 •

edited

Loading

Restack on protected main (`a243f18`) + docstring-contract repair