feat(longitudinal): consolidate lagged correlation and discreteDRIFTstd - #310
seonghobae wants to merge 299 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough
Changes종단 모델링 계약
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~60 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Caller
participant longitudinal_core
participant EventTimeInterval
participant NumericalRecovery
participant LongitudinalError
Caller->>longitudinal_core: 시간 관측과 수치 입력 전달
longitudinal_core->>EventTimeInterval: 이벤트 간격 검증
EventTimeInterval-->>longitudinal_core: 승인된 typed interval 반환
longitudinal_core->>NumericalRecovery: CWC, occasion-mean 또는 표준화 복구 실행
NumericalRecovery-->>longitudinal_core: 추정량 또는 검증 오류 반환
longitudinal_core-->>Caller: 결과 또는 LongitudinalError 반환
Merge Risk: 🟡 Moderate · up to The current head can return an incorrect mixed-sign mean and no longer schedules the required hourly workflow. Current-head validation evidence must also be refreshed, so these issues should be resolved before merge. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation
Full details: Out of Scope Changes checkExplanation
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@opencode-agent review | Independent exact-current-head formal review requested for |
|
Current-head authority update: ordinary-forward review repair is now |
|
Terminal current-head evidence for |
|
Fresh owner-path authority refresh (2026-09-12): central CodeQL bootstrap Current-head CodeQL run An explicit This central-control movement does not change #495 scientific acceptance or the TEPP numerical-owner RED. Keep |
|
Tip For best results, initiate chat on the files or code changes.
The live Draft state of The queued protected-handler run does not provide terminal handler or SARIF evidence. The current CodeQL consumer failures remain a producer-after-consumer settlement issue. The later GREEN dispatch producer does not change those failed consumer results. The unavailable CodeRabbit approval path does not satisfy the independent-approval requirement. PR ✏️ Learnings added
🧠 Learnings usedYou are interacting with an AI system. |
|
Fresh central-gate authority correction for this unchanged TEPP head
Fresh same-head Required CodeQL #2106 formal reviews remain COMMENTED only and |
|
Central-gate authority refresh for current
The central adapter currently preserves provider-body redaction but exposes only byte counts, so I filed Therefore #310's #495 estimand, Monte Carlo acceptance, and sole mixed-sign half-ULP product RED are unchanged. Do not rerun/push this TEPP head merely for review freshness, do not consume mutable fast-mlsirm, and do not mark Ready until the existing causal landing bar closes. |
|
Fresh external-owner authority for unchanged TEPP exact head
No TEPP estimand or arithmetic changes follow from these owner-state updates. |
|
Owner-path currentization (2026-09-13 KST): reusable numerical/GPU prerequisite This does not change the scientific/numerical dependency boundary. #1717 remains Draft/open/mergeable and the real GPU RED remains the per-shader-stage SwiftShader limit 10 versus the marginal E-step/score topology using 17/18 storage buffers. No predecessor GPU/CI GREEN transfers to
|
|
Owner-state handoff (supersedes only the stale fast-mlsirm head/base lines in the PR body; #495 estimand/scientific acceptance is unchanged):
Therefore |
|
Owner-path refresh (2026-09-13 KST): Longitudinal scientific authority on this PR is unchanged; do not alter the #495 estimand/denominator/Monte Carlo contract. Reusable numerical prerequisites have moved. |
|
Fresh numerical-owner handoff: |
|
Fresh exact-head gate follow-up for the numerical prerequisite: |
|
Superseding the earlier queued-handler note: exact protected handler |
|
Fresh owner-state handoff superseding the stale fast-mlsirm heads in this PR body (scientific estimand/acceptance is unchanged):
Therefore |
|
Correction to the fresh #1717 handoff above: the branch pins Accordingly, the proposed packing direction is only a candidate until the owner records the controlled adapter's combined limit: E-step target 10 storage + 1 uniform requires combined >=11; score target 8 storage + 1 uniform requires combined >=9. The owner must also validate packed arena binding size/buffer size/alignment. Owner correction: fast-mlsirm #1717 comment This does not change TEPP's scientific contract: |
|
Fresh numerical-owner handoff for this exact scientific head
The local mixed-sign half-ULP RED therefore remains the correct consumer-side blocker. Do not weaken it, skip it, or reinterpret the scientific target. |
|
Owner-state handoff, current exact heads: reusable numerical prerequisite |
|
Fresh numerical-owner handoff: |
|
Fresh numerical-owner authority supersedes the older #1717 head references in this PR body. On that exact head, controlled #1717 is still not merge-authorized: Required CodeQL PR
|
|
Numerical-owner handoff refresh: fast-mlsirm #1717 is now |
|
Owner-path refresh only; no TEPP numerical/scientific contract change. fast-mlsirm protected
Therefore |
1 participant
Longitudinal Modeling landing vehicle
This Draft is TEPP's Longitudinal Modeling landing vehicle for typed event-time lagged association, stationary/discrete drift-diffusion standardisation, within/between decomposition, CWC and occasion-mean irregular residual composition, explicit irregular-rate estimand identity, known-truth recovery, and the DDD boundary that keeps reusable domain-neutral numerical arithmetic out of TEPP ownership.
Exact authority
ba10820e0d28cc33d1b91ef37f6f6d163b3d91e9;main@a243f18da4a4ca8a8d068c39922537f1f8ed6ad0;ContextualWisdomLab/fast-mlsirm, implementation PR #1816;ContextualWisdomLab/fast-mlsirm#1717.Mergeability is not scientific, review, security, or release acceptance. Predecessor checks and reviews are lineage only and never transfer across a head/base change.
#495 scientific contract
tepp.irregular_rate.lag_pair_average.v1/IrregularRateEstimand::LagPairAverageV1is the implemented pair-weighted target.tepp.irregular_rate.unit_average.v1/UnitAverageV1remains typed but intentionally fail-closed until the reusable immutable finite-mean dependency exists.IrregularRateSummarypreserves candidate/contributing units, candidate/admitted/refused pairs, and refusal populations; follow-up multiplicity is not silently reinterpreted as a design or multiple-membership weight.The 4,096-replicate informative-missingness contract records attempted/recovered/failed replicates, truth conditioned on admitted lag-pair counts, bias with Monte Carlo uncertainty, RMSE/stability, interval coverage with uncertainty, and exact replay. These are scientific acceptance oracles, not hidden production implementation of
UnitAverageV1.Current TEPP exact-head RED
Rust Foundation
34672270380onba10820...remains terminal RED with 1,574 PASS / 1 FAIL / 0 skipped across 1,575 tests. The sole failure ismixed_sign_mean_rounding_contract::half_ulp_tail_changes_the_final_mixed_sign_rounding: actual bits5080060379673919488, correctly rounded expected5080060379673919487.That RED is owner-boundary evidence. TEPP must not add another generic summation kernel, relax the expected bits, skip/xfail the test, rewrite coverage, or pin mutable fast-mlsirm source. Documentation Quality and Semgrep on this TEPP head are GREEN, but there is no qualifying independent current-head
APPROVEDreview and exact-head release acceptance is not satisfied.Current fast-mlsirm owner state
81d3ed2275a785cd3b136f267b208c0d2c166dd3, open / Ready / mergeable on protectedmain@a712995b1c22230bc7fcc7f693ae4ad88cb363f4. Ordinary-forward restack preserved protected-main changes and restored the buyer-delivery packet + detached SHA-256/source-commit integrity contract lost during overlap resolution. Fresh exact-head CI, Security Scan, CodeQL/CodeQL PR, Semgrep, and ClusterFuzzLite are pending/queued with no jobs allocated. A repository-wide query showed 161 queued workflow runs, so the current state is runner backlog rather than a code/scientific verdict. No blind rerun or predecessor-GREEN transfer is authorized.3a1176998103332d26c9fb211fe2bf954dabd428, open / Draft / mergeable. The correctly rounded finite binary64 mean candidate remains mutable, stacked on #1717, and non-consumable by TEPP.v0.11.4, immutable and published2026-09-18T08:14:12Z. It predates the current #1717/#1816 deltas, so it does not contain or authorize the finite-mean candidate required byUnitAverageV1.Documentation ownership
#435 remains the single-writer documentation authority. Its current
docs/product-technical-gap-baseline.mdnow records this exact #310/#1717/#1816/v0.11.4 boundary.docs/TRACEABILITY.mdstill needs the corresponding current immutable-owner chain and the #491/#488 resource/cardinality row; that debt belongs to #435, not this branch.Landing bar
Keep this PR Draft until the causal chain closes in order:
No self-approval, bypass merge, force push, destructive rebase, gate weakening, source-rewriting coverage trick, mutable dependency, skip/xfail, CPU-as-GPU substitution, provider/model hard-code, or purpose-complete self-modifying workflow is authorized.