feat(document-records): add governed HR document evidence - #98
feat(document-records): add governed HR document evidence#98seonghobae wants to merge 24 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughDocumentRecordEvidence 패키지를 추가했습니다. 최소화된 HR 문서 메타데이터와 무결성 digest를 검증합니다. 관련 ADR, 참조 문서, 추적성 문서 및 설치 휠 품질 검증 워크플로를 추가했습니다. ChangesDocument Record Evidence
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant build_document_record_evidence
participant DocumentRecordEvidence
Caller->>build_document_record_evidence: 키워드 인자 전달
build_document_record_evidence->>DocumentRecordEvidence: 객체 생성 및 입력 검증
Caller->>DocumentRecordEvidence: canonical_json 호출
DocumentRecordEvidence-->>Caller: 검증된 canonical JSON 반환
Merge Risk: ⚪ Minimal · up to The PR adds a constrained, evidence-only HR document boundary with successful exact-head validation and no actionable merge-blocking risk remaining beyond normal independent review and repository protection checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fresh owner-stack repair downstream is complete: #107 no longer points at this PR's predecessor This makes #98 the actual next document_records foundation blocker. Its live state remains Draft · non-mergeable against protected |
Adopt current protected develop through an ordinary two-parent merge while preserving the governed document-record evidence domain/docs/package delta. Keep #161 repository-workflow consolidation authoritative: do not resurrect the obsolete feature-local quality workflow. Keep the protected foundation manifest and root changelog as current authority; the package changelog and PR authority retain the document-record evidence release delta without carrying stale Active-PR metadata from the old base. Signed-off-by: Seongho Bae <me@seonghobae.me>
Adopt current #98 authority through an ordinary two-parent merge while preserving only the valid document-record persistence domain, ADR, traceability, and PostgreSQL contract delta. Keep #161 repository workflow consolidation authoritative: retire the obsolete persistence-local workflow and stale root manifest/Foundation registrations rather than resurrecting them. Package-neutral Foundation admission remains owned by the canonical Foundation stack. Signed-off-by: Seongho Bae <me@seonghobae.me>
Current authority — 2026-09-12
Current exact head is
ec39bfa9bcb73b2b7730a0a6115b2e484d78acb2, based on protecteddevelop@eb9757f8649aaad026a9865508d9aad50c1a7a4f. Live state is open · Draft · mergeable. The document-record evidence delta remains valid and is not a Close candidate.This head is an ordinary two-parent, non-force reconciliation of predecessor
6a9f3e214079e2b46bba9776a862f194b899f0e4with current protecteddevelop. The resolved tree preserves the governedDocumentRecordEvidenceADR/doctoring/traceability and package source/tests while keeping #161 repository-owned workflow consolidation authoritative. The obsolete feature-local.github/workflows/document-record-evidence-quality.ymlis intentionally not resurrected.The old-base root
CHANGELOG.mdline describing an “Active-PR” slice and its corresponding old manifest reseal were not carried forward as authoritative data. That status prose was stale after protected-parent reconciliation and is already represented by the package changelog plus this PR authority; protectedCHANGELOG.mdandmanifest.jsonremain byte-current fromdevelop, avoiding reintroduction of old workflow inventory/provenance. No production/test/fixture/contract/evidence delta from the document-record package was dropped.Exact-head evidence
34625702215: SUCCESS, but not package acceptance. Protected Foundation’s explicit owned-test list does not executepackages/document-record-evidence, so this is a demonstrated false-green for a newly introduced owned package. Current-head adopter evidence was handed to canonical package-neutral Foundation owner ci: enforce declared Python package compatibility #259 (5637945375).34625702203: SUCCESS on this exact head.34625700486: SUCCESS on exactec39bfa...(completed 2026-09-11 17:21:08Z).34625700536: SUCCESS on exactec39bfa...(completed 2026-09-11 17:49:32Z). This terminal result supersedes the earlier in-progress snapshot; elapsed time was not treated as a timeout verdict.34625702181: terminal FAILURE only at central Dependency Review support detection after exact checkout/verification; actual Dependency Review was skipped while Trivy/Scorecard/OSV siblings succeeded. Current-head canary remains with.github#810(5637952624).34625702267: terminal FAILURE reproducing the central consumer-before-producer ordering defect. The authoritative dispatch producer later succeeded, but both required compatibility consumers had already failed. Current-head chronology remains with.github#2040(5637967282).All predecessor hosted results are historical after the merge commit. All currently visible inline review threads are resolved, but there is still no qualifying current-head independent
APPROVEDreview. Before Ready, this exact head still needs actual package discovery/execution with 100% owned statement/branch coverage, repaired applicable central Security/CodeQL gates, and a qualifying independent approval.Stack / owner order
#107 is the durable PostgreSQL persistence child and currently stacks on this exact #98 authority. #107 must not transfer predecessor GREEN and remains Draft until canonical Foundation can actually discover its new package/PostgreSQL contracts. Issue #309 owns the later
document_recordsuncertain-retry/idempotent persistence command/result contract; #308 owns return/delete completion receipts and recovery-aware deletion. Consumers such as #307 may consume only released/versioned owner contracts.Do not revive feature-local workflows, self-approve, routinely bypass, force-push, destructively rebase, create no-op retriggers, add sleeps/polling to leaf workflows, or weaken gates.