Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 8 additions & 28 deletions .github/workflows/product.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Product

on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review, converted_to_draft, closed]
types: [opened, synchronize, reopened, ready_for_review]
push:
branches: [main]

Expand All @@ -15,7 +15,6 @@ permissions:

jobs:
rust-quality:
if: ${{ github.event_name != 'pull_request' || (github.event.action != 'closed' && github.event.pull_request.draft == false) }}
runs-on: ubuntu-24.04
env:
COVERAGE_TOOLCHAIN: nightly-2026-08-20
Expand Down Expand Up @@ -63,37 +62,18 @@ jobs:
- name: Exact owned coverage
run: ./scripts/check_coverage.sh

- name: Validate public JSON contract
run: |
npx --yes ajv-cli@5.0.0 compile \
--spec=draft2020 \
-s contracts/semantic-candidate.schema.json
npx --yes ajv-cli@5.0.0 test \
--spec=draft2020 \
-s contracts/semantic-candidate.schema.json \
-d contracts/fixtures/semantic-candidate.valid.json \
--valid
npx --yes ajv-cli@5.0.0 test \
--spec=draft2020 \
-s contracts/semantic-candidate.schema.json \
-d contracts/fixtures/semantic-candidate.invalid-whitespace.json \
--invalid
npx --yes ajv-cli@5.0.0 test \
--spec=draft2020 \
-s contracts/semantic-candidate.schema.json \
-d contracts/fixtures/semantic-candidate.invalid-published-truth.json \
--invalid
npx --yes ajv-cli@5.0.0 test \
--spec=draft2020 \
-s contracts/semantic-candidate.schema.json \
-d contracts/fixtures/semantic-candidate.invalid-state-truth-mismatch.json \
--invalid
- name: Install pinned JSON Schema validator
run: npm ci --ignore-scripts --no-audit --no-fund

- name: Validate public JSON contracts
run: npm run check:json-contracts

- name: Lockfile freshness
run: |
cargo generate-lockfile --locked
git ls-files --error-unmatch Cargo.lock >/dev/null
test -z "$(git status --porcelain=v1 --untracked-files=all -- Cargo.lock)"
git ls-files --error-unmatch package-lock.json >/dev/null
test -z "$(git status --porcelain=v1 --untracked-files=all -- Cargo.lock package-lock.json)"

- name: Clean working tree
run: test -z "$(git status --porcelain=v1 --untracked-files=all)"
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/target
/node_modules
*.profraw
coverage.json
.DS_Store
9 changes: 9 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,12 @@ ConceptWeave owns automatic, evidence-bound **Semantic Model Engineering**. Do n
- Owned production coverage target is 100% line/function/region/branch where tooling exposes it.
- Never suppress deprecation warnings; fix causes.
- Never force-push shared branches, self-approve, fabricate checks, or weaken branch protection.

## Procedural model engineering (Proposed, issue #42)

Follow [ADR-PG-20260910](docs/adr/pg_20260910_procedural_model_engineering.md).
ConceptWeave owns evidence-bound procedural authoring, semantic validation and model
publication; Noema owns execution-local guidance/lifecycle. The local draft schemas
and their shape tests grant no publication, runtime or tool authority. Preserve the
existing candidate schema and Noema implementation. Rust semantic validation and
released cross-product contracts must precede any runtime integration.
11 changes: 11 additions & 0 deletions ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,14 @@ scripts/ # Deterministic repository-quality helpers
```

Adapters and application services are added only when their bounded responsibility exists; generic `utils`, `helpers`, or `services` dumping grounds are prohibited.

## Procedural knowledge profile — Proposed

The existing discovery/validation/publication contexts also own procedure concepts,
advisory relations, evidence alignment and reviewed model revisions. Noema consumes
a released projection for online advice and retains execution/cancellation authority.
CO supplies model calls; CGC owns shared interchange; SDP catalogs releases; EAC owns
the architecture/adoption map. Product factual and policy authority do not move.
See [ADR-PG-20260910](docs/adr/pg_20260910_procedural_model_engineering.md) for the
context/aggregate map, UML, source claims, current input-schema implementation and
explicit Rust, governance, projection, security and recovery prerequisites.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ All notable changes to ConceptWeave are documented here.

### Added

- Proposed procedural-model engineering profile: local draft/revision input schemas, structural conformance fixtures and existing Product AJV wiring. ConceptWeave owns authoring/validation/publication; Noema retains runtime guidance. No Rust semantic validator, model call, release or activation is delivered by this input-contract slice. Issue #42; ADR-PG-20260910.

- Initial ConceptWeave product, DDD, security, test, and operability baselines.
- Rust 1.98.0 `conceptweave-domain` foundation with evidence-bound semantic candidate contracts.
- Fail-closed Draft -> Proposed -> Validated -> Reviewed -> Published lifecycle with explicit rejection and supersession.
Expand Down
6 changes: 6 additions & 0 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@ Follow `AGENTS.md`, `ARCHITECTURE.md`, accepted ADRs, and the organization maste
ConceptWeave's core invariant is: **inference is not authority**. Every generated concept, relation, constraint, dimension, measure, or physical mapping must retain evidence and pass the explicit governance lifecycle before publication.

Keep domain logic in bounded domain modules, LLM/provider logic behind ports/adapters, and source/consumer systems independent. Prefer deterministic validation and explicit abstention over plausible unsupported output.

For procedural knowledge, apply the same inference/authority separation through
[ADR-PG-20260910](docs/adr/pg_20260910_procedural_model_engineering.md) and issue #42.
Do not turn a shape-valid authoring draft, training-partition label, or digest string
into authenticated evidence. Noema's execution-local projection is not a competing
ConceptWeave publisher, and this schema slice is not a deployed self-evolving agent.
52 changes: 52 additions & 0 deletions contracts/fixtures/procedural-authoring.cases.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
"validation_scope": "input_shape_only",
"fixture_data_policy": "synthetic_unit_test_only",
"case_rows": [
{"case_name":"valid_inferred_model","base_name":"model","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[]},
{"case_name":"valid_training_revision","base_name":"revision","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[]},
{"case_name":"valid_empty_transition_skeleton","base_name":"model","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_edges"],"field_value":[]}]},
{"case_name":"valid_eight_locale_labels","base_name":"model","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"locale_labels"],"field_value":{"ko":"Unit fixture label","en":"Unit fixture label","ja":"Unit fixture label","zh":"Unit fixture label","vi":"Unit fixture label","es":"Unit fixture label","de":"Unit fixture label","fr":"Unit fixture label"}}]},
{"case_name":"valid_requires_advisory_relation","base_name":"model","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_edges",0,"relation_type"],"field_value":"requires"}]},
{"case_name":"valid_enables_advisory_relation","base_name":"model","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_edges",0,"relation_type"],"field_value":"enables"}]},
{"case_name":"valid_skill_procedure","base_name":"model","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"procedure_kind"],"field_value":"skill_procedure"}]},
{"case_name":"valid_task_state","base_name":"model","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"procedure_kind"],"field_value":"task_state"}]},
{"case_name":"valid_steward_revision","base_name":"revision","shape_valid":true,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["proposal_origin"],"field_value":"steward_authored"}]},
{"case_name":"reject_published_state","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["publication_state"],"field_value":"published"}]},
{"case_name":"reject_authoritative_truth","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["truth_status"],"field_value":"authoritative"}]},
{"case_name":"reject_inferred_promotion_flag","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["activation_authorized"],"field_value":true}]},
{"case_name":"reject_missing_source_set","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["source_evidence"],"field_value":[]}]},
{"case_name":"reject_blank_source_location","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["source_evidence",0,"location"],"field_value":" "}]},
{"case_name":"reject_mutable_source_digest","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["source_evidence",0,"source_digest"],"field_value":"main"}]},
{"case_name":"reject_uppercase_digest","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["source_evidence",0,"source_digest"],"field_value":"sha256:AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"}]},
{"case_name":"reject_node_without_evidence","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"source_evidence"],"field_value":[]}]},
{"case_name":"reject_duplicate_node_record","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes"],"field_value":[{"procedure_id":"read_review","procedure_kind":"reasoning_step","locale_labels":{"ko":"리뷰 근거 읽기","en":"Read review evidence"},"source_evidence":[{"source_id":"unit_fixture_review_sop","source_digest":"sha256:1111111111111111111111111111111111111111111111111111111111111111","location":"section_2/step_1"}]},{"procedure_id":"read_review","procedure_kind":"reasoning_step","locale_labels":{"ko":"리뷰 근거 읽기","en":"Read review evidence"},"source_evidence":[{"source_id":"unit_fixture_review_sop","source_digest":"sha256:1111111111111111111111111111111111111111111111111111111111111111","location":"section_2/step_1"}]}]}]},
{"case_name":"reject_duplicate_edge_record","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_edges"],"field_value":[{"source_procedure_id":"read_review","relation_type":"leads_to","target_procedure_id":"verify_finding","condition":{"ko":"검토할 근거가 있습니다.","en":"Evidence is available for review."},"guidance":{"ko":"현재 수정본에서 지적 사항을 재현합니다.","en":"Reproduce the finding against the current revision."},"pitfalls":{"ko":"이전 수정본의 통과 기록을 승인 근거로 사용하지 않습니다.","en":"Do not treat an older revision result as approval."},"source_evidence":[{"source_id":"unit_fixture_review_sop","source_digest":"sha256:1111111111111111111111111111111111111111111111111111111111111111","location":"section_2/step_1"}]},{"source_procedure_id":"read_review","relation_type":"leads_to","target_procedure_id":"verify_finding","condition":{"ko":"검토할 근거가 있습니다.","en":"Evidence is available for review."},"guidance":{"ko":"현재 수정본에서 지적 사항을 재현합니다.","en":"Reproduce the finding against the current revision."},"pitfalls":{"ko":"이전 수정본의 통과 기록을 승인 근거로 사용하지 않습니다.","en":"Do not treat an older revision result as approval."},"source_evidence":[{"source_id":"unit_fixture_review_sop","source_digest":"sha256:1111111111111111111111111111111111111111111111111111111111111111","location":"section_2/step_1"}]}]}]},
{"case_name":"reject_empty_node_set","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes"],"field_value":[]}]},
{"case_name":"reject_empty_identifier","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"procedure_id"],"field_value":""}]},
{"case_name":"reject_whitespace_identifier","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["entry_procedure_id"],"field_value":"read_review\n"}]},
{"case_name":"reject_unknown_procedure_kind","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"procedure_kind"],"field_value":"authorization"}]},
{"case_name":"reject_permission_relation","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_edges",0,"relation_type"],"field_value":"grants_permission"}]},
{"case_name":"reject_edge_execute_field","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_edges",0,"execute"],"field_value":true}]},
{"case_name":"reject_missing_guidance","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"remove","field_path":["procedure_edges",0,"guidance"]}]},
{"case_name":"reject_blank_guidance","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_edges",0,"guidance"],"field_value":{"en":" "}}]},
{"case_name":"reject_invalid_locale_value","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"locale_labels","ko"],"field_value":4}]},
{"case_name":"reject_unsupported_locale","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"locale_labels"],"field_value":{"xx":"Test"}}]},
{"case_name":"reject_empty_labels","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"locale_labels"],"field_value":{}}]},
{"case_name":"reject_tool_without_contract","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"remove","field_path":["procedure_nodes",1,"tool_contract_ref"]}]},
{"case_name":"reject_tool_trailing_newline_digest","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",1,"tool_contract_ref","artifact_digest"],"field_value":"sha256:2222222222222222222222222222222222222222222222222222222222222222\n"}]},
{"case_name":"reject_inline_foreign_truth","base_name":"model","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["procedure_nodes",0,"semantic_refs"],"field_value":[{"authority_ref":"ContextualWisdomLab/Orgmetra","release_ref":"unit_fixture_release","artifact_digest":"sha256:4444444444444444444444444444444444444444444444444444444444444444","object_ref":"job_concept","employee_table":[]}]}]},
{"case_name":"reject_revision_holdout_partition","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["evidence_partition"],"field_value":"holdout"}]},
{"case_name":"reject_revision_self_approval","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["decision_authority"],"field_value":"approved"}]},
{"case_name":"reject_revision_published_state","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["proposal_state"],"field_value":"published"}]},
{"case_name":"reject_revision_holdout_scores","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["validation_scores"],"field_value":[1.0]}]},
{"case_name":"reject_revision_raw_trajectory","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["raw_trajectory"],"field_value":"private content"}]},
{"case_name":"reject_revision_no_training_evidence","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["training_evidence"],"field_value":[]}]},
{"case_name":"reject_revision_stale_label_digest","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["base_model_ref","artifact_digest"],"field_value":"main"}]},
{"case_name":"reject_revision_nested_authority","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["candidate_model","truth_status"],"field_value":"authoritative"}]},
{"case_name":"reject_revision_blank_rationale","base_name":"revision","shape_valid":false,"semantic_expectation":"not_evaluated","changes":[{"operation":"set","field_path":["change_rationale"],"field_value":" "}]},
{"case_name":"known_gap_dangling_endpoint","base_name":"model","shape_valid":true,"semantic_expectation":"must_reject_dangling_endpoint","changes":[{"operation":"set","field_path":["procedure_edges",0,"target_procedure_id"],"field_value":"absent_node"}]},
{"case_name":"known_gap_missing_entry","base_name":"model","shape_valid":true,"semantic_expectation":"must_reject_missing_entry","changes":[{"operation":"set","field_path":["entry_procedure_id"],"field_value":"absent_entry"}]},
{"case_name":"known_gap_same_node_id_different_record","base_name":"model","shape_valid":true,"semantic_expectation":"must_reject_duplicate_identity","changes":[{"operation":"set","field_path":["procedure_nodes",1,"procedure_id"],"field_value":"read_review"}]},
{"case_name":"known_gap_scope_evidence_authenticity","base_name":"revision","shape_valid":true,"semantic_expectation":"requires_authenticated_evidence_and_exact_base_scope","changes":[]}
]
}
Loading