ops(queue): enroll DiskSage/LineageWeave/Noema/quarantine/OriginWeave on refreshed #1150 - #2241
Merged
Merged
Conversation
…main-successor # Conflicts: # CHANGELOG.md # organization_commercial_readiness_fixtures.py # scripts/ci/organization_commercial_readiness_loop.py
…jobs, job-scoped age, and incomplete-PR retry
Devin Review flagged four real bugs in scripts/ci/actions_queue_health.py:
- _run_identity compared a run's own head_sha (the checked-out BASE commit
for pull_request_target runs) against the open PR's head_sha, so active
required-workflow runs were wrongly labeled obsolete and their job
evidence was never fetched. Now compares against the linked pull-request
entry's head_sha instead. Fixing this also exposed a related round-trip
bug: _normalise_run only understood the raw GitHub link shape
({"head": {"sha": ...}}), so re-normalising an already-normalised run
loaded from a collected snapshot (as build_report does) silently zeroed
out the very head_sha the fix depends on. _normalise_run now accepts
both shapes.
- _normalise_pull_request accepted head/base objects whose nested
head_sha/base_ref/base_repository/updated_at fields were present but
empty, instead of treating that as an incomplete identity. A transient,
partially populated API response was silently accepted rather than
triggering collect_snapshot's bounded retry.
- _job_state treated GitHub's "waiting" job status (paused on an
environment/deployment approval) as unclassified "unknown" evidence,
dropping it out of pending_job_count and leaving no blocker/action.
It is now "waiting_approval": pending, with its own blocker distinct
from a runner-capacity SLO breach. pending_job_count now derives from
an explicit is_pending field rather than an execution_state string
prefix, so this and any future non-"queued_" pending state stays
counted.
- build_report measured every job's queue age from the parent run's
creation time, so a later job in an already in-progress run (e.g. one
gated by `needs:`) that had only just become eligible inherited the
whole run's age and could trigger a false capacity-breach alert.
_normalise_job now preserves each job's own created_at, and build_report
prefers it, falling back to the run's created_at only for the synthetic
run-level job used when no job evidence was fetched.
Added regression tests for each scenario (unit-level and full
collect_snapshot -> build_report pipeline) and updated the doctoring doc.
100% statement/branch coverage and 100% docstring coverage retained.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KPmJErfkcHer4UVEgrQxUX
Preserve the complete queue-health RED/GREEN lineage while integrating current protected main with a two-parent, non-force reconciliation. The post-merge tree uses current main as the base and overlays only the 13 queue-health owner files; the compared path sets do not overlap.
Preserve the complete queue-health owner delta while integrating current protected main with a two-parent, non-force reconciliation. The base-to-current-main comparison does not touch any of the 13 queue-health PR paths, so the current protected tree is used as the base and only those exact owner blobs are overlaid. Fresh exact-head hosted checks remain required.
Ordinary non-force reconciliation of main@7f07029381a9ca770d0a68b7f3938dd652799d4d into codex/pr1142-current-main-successor. No predecessor evidence transfers; #1150 must reacquire exact-head gates.
Ordinary non-force reconciliation of protected main@91be6442906c7b6b4f600272c953699708394327 into the canonical queue-health owner. The six Pingora/OpenCode mainline paths do not overlap the 13 queue-health owner paths; predecessor evidence does not transfer and the resulting exact head must reacquire gates.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
September 17, 2026 15:58
Contributor
Author
|
Lead merge authorization (run_a9475d4b375c): Admin-merging ahead of queued CI. Local evidence on head
Merged ahead of org queue saturation. |
seonghobae
deleted the
seonghobae/queue-health-enroll-2211-successor
branch
September 17, 2026 15:58
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main(clean merge; was 75 behind) then preserves the stacked allowlist enrollments (LineageWeave,OriginWeave,disksage,noema,quarantine-sandbox-runtime) that individual enrollment PRs would otherwise race.main; does not claim carryover of ops(queue): enroll mhtml-etl-gateway in queue-health evidence #2212/mhtml-etl-gateway, ops(queue): enroll pg-llm-batch #2219/pg-llm-batch, or behavioral fix(queue): preserve terminal pre-execution failures #2213.72 passedlocally (test_actions_queue_health_contract.py+ related queue-health tests).Test plan
python3 -m pytest tests/test_actions_queue_health_contract.py tests/test_actions_queue_health.py tests/test_actions_queue_health_startup_failure.py tests/test_actions_queue_health_cancelled_before_runner.py tests/test_actions_queue_health_snapshot_consistency.py tests/test_actions_queue_health_post_evidence_retry.py -qParent: #1150 · Predecessor: #2211
Made with Cursor