fix(python-security): stop reporting pip-audit transport failures as vulnerabilities - #2240
Merged
Merged
Conversation
…vulnerabilities Closes #2158. Supersedes #2186 (stale, 114 commits behind main). The hard gate folded every non-zero pip-audit exit into one message asserting known-vulnerable dependencies, so a PyPI advisory-query ConnectionResetError with no findings read as a security finding. Each invocation now runs through run_audit(), which keeps the gate closed but classifies findings vs audit-service/transport failure. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Lead merge authorization (run_a9475d4b375c): Admin-merging ahead of queued CI. Local evidence on head
Merged ahead of org queue saturation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainand cannot land cleanly).pip-auditon PATH (findings / ConnectionResetError / clean / catch-all gone).Change
Each pip-audit invocation goes through
run_audit <label> <args…>:status=1(fail-closed preserved);Found N known vulnerabilit…→::error::… found known-vulnerable …;::error::… could not complete … audit-service/transport failure … rerun ….No retry budget (directive 3.1). Call sites and flags unchanged.
Test plan
pytest tests/test_python_security_pip_audit_failure_classification.py(4/4)pytest tests/test_workflow_file_detection_pipefail_regression.py(unaffected)Made with Cursor