Skip to content

fix(python-security): stop reporting pip-audit transport failures as vulnerabilities - #2240

Merged
seonghobae merged 1 commit into
mainfrom
seonghobae/pip-audit-transport
Sep 17, 2026
Merged

seonghobae merged 1 commit into
mainfrom
seonghobae/pip-audit-transport

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

Change

Each pip-audit invocation goes through run_audit <label> <args…>:

  • non-zero exit still sets status=1 (fail-closed preserved);
  • log contains Found N known vulnerabilit…::error::… found known-vulnerable …;
  • otherwise → ::error::… could not complete … audit-service/transport failure … rerun ….

No retry budget (directive 3.1). Call sites and flags unchanged.

Test plan

  • pytest tests/test_python_security_pip_audit_failure_classification.py (4/4)
  • pytest tests/test_workflow_file_detection_pipefail_regression.py (unaffected)
  • Hosted python-security / required review checks on this head

Made with Cursor

…vulnerabilities

Closes #2158. Supersedes #2186 (stale, 114 commits behind main). The hard gate
folded every non-zero pip-audit exit into one message asserting known-vulnerable
dependencies, so a PyPI advisory-query ConnectionResetError with no findings
read as a security finding. Each invocation now runs through run_audit(), which
keeps the gate closed but classifies findings vs audit-service/transport failure.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 38427c1f-aedc-4672-ac03-a3c53da40c7c

📥 Commits

Reviewing files that changed from the base of the PR and between a1d0034 and eba48c1.

📒 Files selected for processing (2)
  • .github/workflows/python-security.yml
  • tests/test_python_security_pip_audit_failure_classification.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Lead merge authorization (run_a9475d4b375c): Admin-merging ahead of queued CI.

Local evidence on head eba48c1:

Merged ahead of org queue saturation.

@seonghobae
seonghobae merged commit 31cce5f into main Sep 17, 2026
6 of 18 checks passed
@seonghobae
seonghobae deleted the seonghobae/pip-audit-transport branch September 17, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python-security: pip-audit transport/exception failures are reported as "known-vulnerable Python dependencies"

1 participant