Skip to content

docs(queue): mark retired org sweep as historical - #2092

Open
seonghobae wants to merge 1 commit into
mainfrom
docs/org-queue-sweep-history-1796
Open

docs(queue): mark retired org sweep as historical#2092
seonghobae wants to merge 1 commit into
mainfrom
docs/org-queue-sweep-history-1796

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • mark the retired organization-wide queue-hygiene sweep as superseded
  • document current scheduler and stale-run ownership boundaries
  • add a contract preventing the historical runbook from being mistaken for current behavior

Closes #1796

Verification

  • python -m pytest -q tests/test_org_queue_sweep_documentation_contract.py (1 passed)
  • python -m compileall -q tests/test_org_queue_sweep_documentation_contract.py
  • git diff --check

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: baca6148-f568-4165-ba13-34a079680cf3

📥 Commits

Reviewing files that changed from the base of the PR and between cb0872c and d31a037.

📒 Files selected for processing (2)
  • docs/doctoring/org-queue-sweep-rotation.md
  • tests/test_org_queue_sweep_documentation_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cwl-noema-review cwl-noema-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noema LLM review

The PR is documentation-only plus a corresponding contract test. It adds a clear supersession notice to the org-queue-sweep rotation runbook, reframes the former queue-hygiene ownership as historical, and adds a lightweight pytest contract asserting the new wording. The test path resolution is correct and all asserted substrings appear in the added documentation lines.

Reviewed changed lines

  • docs/doctoring/org-queue-sweep-rotation.md:3 (RIGHT): Starts the supersession notice with a clear 'Superseded for queue hygiene' marker that recontextualizes the document without deleting historical content.
  • docs/doctoring/org-queue-sweep-rotation.md:34 (RIGHT): Current ownership boundary bullet clarifies that the organization sweep no longer repeats an Actions inventory, while the rotation algorithm remains intact below.
  • docs/doctoring/org-queue-sweep-rotation.md:35 (RIGHT): States that the organization sweep does not repeat an Actions inventory per repository, matching the contract test assertion.
  • tests/test_org_queue_sweep_documentation_contract.py:6 (RIGHT): Uses Path(file).resolve().parents[1] from tests/ to locate the runbook at the repository root; resolves to the changed file correctly.
  • tests/test_org_queue_sweep_documentation_contract.py:10 (RIGHT): Plain pytest-discoverable test function performs substring assertions on the newly added runbook phrases without external dependencies.
  • tests/test_org_queue_sweep_documentation_contract.py:11 (RIGHT): Asserts 'Superseded for queue hygiene', matching the added runbook header.
  • tests/test_org_queue_sweep_documentation_contract.py:12 (RIGHT): Asserts 'does not repeat an Actions inventory per repository', matching the new ownership-boundary bullet.
  • tests/test_org_queue_sweep_documentation_contract.py:13 (RIGHT): Asserts '#1878', matching the reference in the supersession notice.
  • tests/test_org_queue_sweep_documentation_contract.py:14 (RIGHT): Asserts 'historical operational evidence', matching the added determination text.

Adversarial validation

  • docs/doctoring/org-queue-sweep-rotation.md:34 (RIGHT) falsified: The added boundary could mislabel a still-current queue-hygiene behavior as retired. — The diff consistently frames the sweep as historical and the boundary bullet explicitly says it does not repeat an Actions inventory; no executable change is introduced.
  • tests/test_org_queue_sweep_documentation_contract.py:6 (RIGHT) falsified: The path traversal could resolve outside the repository or to a different runbook. — The test file is at tests/test_org_queue_sweep_documentation_contract.py, so parents[1] is the repo root, and the appended docs/doctoring/org-queue-sweep-rotation.md matches the changed file path.
  • Residual risk: No concrete regression found. The change is documentation-only with a non-fragile contract test; residual risk is limited to future documentation edits drifting away from the asserted phrases, which is the intended contract.

Findings

  • No blocking findings.
  • Result: APPROVE
  • Head SHA: d31a037746e9e31eefd5331dd6aede5341fbfcbc
  • Reviewer credential: noema-review-github-app-refresh
  • Actor: cwl-noema-review[bot]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(actions): remove duplicate queue hygiene from the organization sweep

1 participant