Skip to content

test(queue): contract the four uncovered cancel-in-progress values (#1988) - #2080

Open
seonghobae wants to merge 1 commit into
mainfrom
test/queue-cancel-contract-consolidated
Open

test(queue): contract the four uncovered cancel-in-progress values (#1988)#2080
seonghobae wants to merge 1 commit into
mainfrom
test/queue-cancel-contract-consolidated

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

계기

Issue #1988의 전수 변이 census에서 워크플로 수준 cancel-in-progress 29개 중 4개가 어떤 테스트로도 계약되지 않은 채 남았습니다.

워크플로 미보호 시 위험
audit-central-ruleset.yml true 조용히 false가 되면 stale audit이 쌓임
sbom-inventory-scheduler.yml false 조용히 true가 되면 실행 중 aggregation이 죽음
pr-auto-rebase.yml false force-push 중간 실행 취소
organization-commercial-readiness-loop.yml false dispatch 추적 소실

변경

  • 값과 근거를 4개 테스트로 고정. pr-auto-rebase.yml은 이미 근거 주석이 있었고, 나머지 두 false 워크플로에는 누락된 근거 주석을 추가
  • 기존 브랜치 4개를 하나의 리뷰 가능한 변경으로 통합

검증

  • uv run pytest -q tests/test_required_workflow_queue_contract.py 73 passed (신규 4건 포함)
  • 인접 계약 테스트 6개 파일 47 passed
  • 이 PR은 #1988의 잔여 4개 값을 닫는 조각이며, 이슈 전체를 닫지 않습니다

Issue #1988's mutation census found four workflow-level cancel-in-progress
values guarded by no test: audit-central-ruleset (true), and
sbom-inventory-scheduler, pr-auto-rebase, organization-commercial-readiness-loop
(false). Pin each value with its rationale: record the two missing on-workflow
rationale comments and assert every group identity the intent depends on.
This consolidates the four per-branch slices into one reviewable change.
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 87a96600-da8b-468d-9ae2-46adbcbe36c9

📥 Commits

Reviewing files that changed from the base of the PR and between cb0872c and ab2dfdc.

📒 Files selected for processing (3)
  • .github/workflows/organization-commercial-readiness-loop.yml
  • .github/workflows/sbom-inventory-scheduler.yml
  • tests/test_required_workflow_queue_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant