fix: scope bearer auth to API host#143
Merged
Merged
Conversation
Only attach the OAuth bearer token when the outgoing request host matches the configured API host, and clear any copied Authorization header before untrusted redirect hops. Add uhttp coverage for same-host redirects, cross-host redirects, and copied Authorization headers on untrusted hosts. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
pquerna
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
uhttptoken transport.Authorizationheader before sending a request to a different host.Why
Cone's SDK HTTP client follows redirects by default. Since bearer auth is injected in the transport on each request, a redirect to a different host could otherwise receive a freshly attached token. This keeps normal same-host redirects working while avoiding credentials on cross-host hops.
Validation
go test ./pkg/uhttpmake lintgo test ./...git diff --check --cached && git diff --check