ci: fix Go workflow versions#142
Merged
Merged
Conversation
c1-squire-dev
Bot
force-pushed
the
paul.querna/fix-golangci-lint-ci
branch
from
a7480a3 to
e779c38
Compare
Checkout before setup-go so dependency caching can see go.sum, use go.mod as the workflow Go version source of truth, and pin golangci-lint to a v2 release compatible with the repo's v2 config. Update the module directive to Go 1.26 and carry that through release workflows instead of stale hardcoded Go versions. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
c1-squire-dev
Bot
force-pushed
the
paul.querna/fix-golangci-lint-ci
branch
from
e779c38 to
0fc8e7b
Compare
c1-squire-dev
Bot
changed the title
pquerna
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
go.modto Go1.26.actions/checkoutbeforeactions/setup-goin both CI workflows so setup-go can seego.sumand restore Go module/build caches correctly.go-version-file: go.modin CI and release workflows so GitHub Actions tracks the repo's declared Go version instead of carrying stale hardcoded Go versions.main cifromgolangci/golangci-lint-action@v3withversion: latesttogolangci/golangci-lint-action@v9pinned togolangci-lint v2.9.0.guyarb/golang-test-annotationstov0.9.0to avoid the old Node 20 action warning.Why
The failed main CI run at https://github.com/ConductorOne/cone/actions/runs/28218801447/job/83595346715 failed in
go-lintbecausegolangci-lint-action@v3resolvedlatestto golangci-lint v1.64.8, but this repo's.golangci.ymlis a v2 config. The same run also warned that setup-go could not findgo.sumbecause checkout happened after setup-go.The first PR run exposed additional workflow drift: CI was still pinned to Go
1.23.xwhile the repo had already moved past that. Usinggo-version-fileremoves that drift, and the module directive now carries the requested Go1.26baseline through CI and release.Validation
go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/ci.yaml .github/workflows/main.yaml .github/workflows/release.yamlgo mod verifymake lintgo test ./...git diff --check