Skip to content

CXH-2565: docs — team Member/Admin grants and re-grant idempotency - #50

Open
hernanvinuesa-c1 wants to merge 1 commit into
mainfrom
CXH-2565/update-docs
Open

hernanvinuesa-c1 wants to merge 1 commit into
mainfrom
CXH-2565/update-docs

Conversation

@hernanvinuesa-c1

Copy link
Copy Markdown

Docs follow-up to CXH-2001 / #46 (released in v0.3.2).

Adds a short paragraph under Capabilities in docs/connector.mdx:

Linear: CXH-2565 (sub-issue of CXH-2001)

🤖 Generated with Claude Code

Follow-up to CXH-2001 (PR #46): document that an Admin grant on an existing
team member promotes the user, that a Member grant does not demote an admin,
and that re-granting an existing membership succeeds without change.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@linear-code

linear-code Bot commented Sep 25, 2026

Copy link
Copy Markdown

CXH-2565

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor
Superseded — see the current review report for commit 691f589dc6b1

Connector PR Review: CXH-2565: docs — team Member/Admin grants and re-grant idempotency

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 8db60734d56f.
Review mode: full
View review run

Review Summary

This PR changes docs only. It adds two paragraphs to docs/connector.mdx covering team Member/Admin entitlements and what happens when a grant is repeated. I scanned the full diff (1 file, +4 lines) for security and correctness problems, then checked each claim against the code:

  • Teams expose member and admin entitlements (pkg/connector/teams.go:96-99).
  • When an Admin grant hits a 409, the connector PATCHes the role to admin, which promotes an existing member (teams.go:187-193).
  • When a Member grant hits a 409, the connector returns GrantAlreadyExists without a PATCH, so an existing admin is not demoted (teams.go:187-188).
  • Repeating a role grant also returns GrantAlreadyExists, through the ErrAlreadyExists join (roles.go:158-159, client.go:441,506).

Repeating an Admin grant for a user who is already admin sends an idempotent PATCH and succeeds. That matches "completes successfully without making a change."

I applied the repo-local criteria. Provisioning depth (F/PR1) was used to confirm the documented Grant behavior. The logging, error-wrapping, span, JSON and breaking-change sections don't apply because no code changed.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Connector PR Review: CXH-2565: docs — team Member/Admin grants and re-grant idempotency

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 8db60734d56f.
Review mode: full
View review run

Review Summary

This PR changes docs only. It adds two paragraphs to docs/connector.mdx covering team Member/Admin entitlements and what happens when a grant is repeated. I scanned the full diff (1 file, +4 lines) for security and correctness problems, then checked each claim against the code:

  • Teams expose member and admin entitlements (pkg/connector/teams.go:96-99).
  • When an Admin grant hits a 409, the connector PATCHes the role to admin, which promotes an existing member (teams.go:187-193).
  • When a Member grant hits a 409, the connector returns GrantAlreadyExists without a PATCH, so an existing admin is not demoted (teams.go:187-188).
  • Repeating a role grant also returns GrantAlreadyExists, through the ErrAlreadyExists join (roles.go:158-159, client.go:441,506).

Repeating an Admin grant for a user who is already admin sends an idempotent PATCH and succeeds. That matches "completes successfully without making a change."

I applied the repo-local criteria. Provisioning depth (F/PR1) was used to confirm the documented Grant behavior. The logging, error-wrapping, span, JSON and breaking-change sections don't apply because no code changed.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.


Reviewed commit: 691f589dc6b1

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found — see the full review report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants