Set grub2_uefi_boot_path to /boot/grub for debian-like - #15116
Set grub2_uefi_boot_path to /boot/grub for debian-like#15116israel-villar wants to merge 1 commit into
Conversation
The debian-like override in product_properties/10-grub.yml set grub2_boot_path=/boot/grub but left grub2_uefi_boot_path at the RHEL default /boot/grub2, which does not exist on Debian. As a result the grub2_uefi_password OVAL checked /boot/grub2/grub.cfg and always failed on Debian even with a valid superuser + password_pbkdf2 in /boot/grub/grub.cfg. Ubuntu (also debian-like) already sets /boot/grub for >18.04; move the setting up to the debian-like block so Debian 11/12/13 get it too. The ubuntu block still overrides to /boot/efi/EFI/ubuntu for <=18.04. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015YN4ez6hrFpegisiLLo3zx
|
Hi @israel-villar. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description:
product_properties/10-grub.yml, thedebian-likeoverride setsgrub2_boot_path=/boot/grubbut leavesgrub2_uefi_boot_pathat the default/boot/grub2.grub2_uefi_boot_path: "/boot/grub"to thedebian-likeblock so Debian 11/12/13 use the correct path. Ubuntu (alsodebian-like) already sets it for> 18.04, and its own block still overrides to/boot/efi/EFI/ubuntufor<= 18.04.Rationale:
/boot/grub2is a RHEL path and does not exist on Debian. On UEFI Debian the full GRUB configuration lives in/boot/grub/grub.cfg; the file under/boot/efi/EFI/debian/is only a stub thatconfigfiles it.grub2_uefi_password(and any other rule keyed ongrub2_uefi_boot_path) checks a non-existent file and always fails on Debian, even whenset superusersandpassword_pbkdf2are correctly present in/boot/grub/grub.cfg.Review Hints:
./build_product debian11 debian12 debian13 ubuntu2404 --datastreamandctestpass.grub2_uefi_passwordgoes fromfailtopassonce the OVAL points at/boot/grub/grub.cfg.