CMP-4716: Bump Go to 1.25.14 to fix stdlib CVEs - #1400
Vincent056 wants to merge 1 commit into
Conversation
Build with Go 1.25.14 in go.mod, build/Dockerfile and the Konflux builder image. This fixes CVE-2026-56860, CVE-2026-56859, CVE-2026-56853, CVE-2026-56858, CVE-2026-56862, CVE-2026-33818, CVE-2026-39821 and CVE-2026-39822 in the Go standard library. The Konflux builder is pinned to the el9 NVR tag because the floating v1.25.14 tag currently resolves to the RHEL 8 build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@Vincent056: This pull request references CMP-4716 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'd focus on |
|
Won't be updating 1.9, 1.10 will be the next Y-Stream |
Description
Compliance Operator 1.9.x is built with Go 1.25.11, which predates the Go 1.25.13 security release. Trivy on the release-1.9 operator image (the "Security scan for Compliance Operator image" check, see #1363) reports 8 HIGH stdlib CVEs in
usr/local/bin/compliance-operator.This bumps the toolchain to Go 1.25.14 in the three places that must stay in sync:
go.mod:go 1.25.14build/Dockerfile:golang:1.25.14(the image the Trivy scan workflow builds)images/operator/Dockerfile:openshift-golang-builderpinned tov1.25.14-202609021839.p0.gedd1cdd.assembly.stream.el9(Konflux)The Konflux builder is pinned to the el9 NVR tag on purpose: the floating
v1.25.14andv1.25tags on brew currently resolve to the RHEL 8 build (golang-1.25.14-1.el8_10), while thev1.25.11we build with today is el9. There is nov1.25.13builder; 1.25.14 is the first patch on the 1.25 line that carries the fixes.CVEs fixed (all Go standard library, fixed in Go 1.25.13): CVE-2026-56860 (net/url), CVE-2026-56859 (encoding/xml), CVE-2026-56853 (net/http), CVE-2026-56858 (html/template), CVE-2026-56862 (crypto/tls), CVE-2026-33818 (encoding/asn1), CVE-2026-39821 (net/http, x/net idna), CVE-2026-39822 (os).
Jira: CMP-4716 (trackers CMP-4580, CMP-4582, CMP-4585, CMP-4588, CMP-4591, CMP-4594, CMP-4387, CMP-4388).
Testing
go mod tidyandgo mod vendorwith Go 1.25.14: no changes.go build,go vet ./...andmake test-unitwith Go 1.25.14: pass (15 packages).govulncheck -mode binaryon the operator binary: 8 findings with 1.25.11 (7 stdlib plus coreos/ignition), 1 with 1.25.14 (only GO-2022-0451 ingithub.com/coreos/ignition@v0.35.0, unrelated to the toolchain).--severity CRITICAL,HIGH --ignore-unfixed) on the operator binary: 8 HIGH with 1.25.11, the same list as the failing check on ROX-35657: Replace pre-modules pseudo-versions with actual dependency versions (backport to release-1.9) #1363; 0 with 1.25.14.go build -tags strictfipsruntimeinside the pinned el9 builder image (go1.25.14 (Red Hat 1.25.14-1.el9),CGO_ENABLED=1): builds and the binary runs.golang.org/x/crypto,golang.org/x/modandgoogle.golang.org/grpc. Those need dependency bumps and are out of scope for the toolchain change.Follow-ups: the same change is needed on
release-1.10andmaster.masteradditionally needs the Prowbuild_rootin openshift/release moved fromrhel-9-golang-1.25-openshift-4.21(Go 1.25.12,GOTOOLCHAIN=local) torhel-9-golang-1.25-openshift-4.22(Go 1.25.14) first, otherwise the unit/verify jobs fail on the go directive.Generated with Claude Code