REFACTOR Make queue_job dependencies optional#2105
Open
ecino wants to merge 1 commit into
Open
Conversation
ecino
commented
Jun 25, 2026
ecino
commented
Member
- NEW module queue_job_sh_safe that will safely use queue_jobs when available and fallback to an alternate mechanism with ir_cron in case the module is not installed.
- This is useful for Nordic using odoo.sh on which queue jobs are prohibited and not optimal for the infrastructure
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
07f6d5f to
a0cad46
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
a0cad46 to
e2d8348
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
e2d8348 to
51f4a7d
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
51f4a7d to
bda7e87
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
bda7e87 to
c7688c2
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
c7688c2 to
5959cc9
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
5959cc9 to
9b2f73a
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
9b2f73a to
28c5143
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
2 times, most recently
from
f21d9e3 to
b886b0a
Compare
ecino
changed the title
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
b886b0a to
ff7a2b5
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
ff7a2b5 to
1f482b5
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
1f482b5 to
fff7252
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
fff7252 to
e577373
Compare
ecino
force-pushed
the
ecino/queue-job-sh
branch
from
e577373 to
07cdaba
Compare
- NEW module queue_job_sh_safe that will safely use queue_jobs when available and fallback to an alternate mechanism with ir_cron in case the module is not installed. - This is useful for Nordic using odoo.sh on which queue jobs are prohibited and not optimal for the infrastructure
| job.delay() | ||
| return job | ||
| else: | ||
| return getattr(self.with_delay(**delay_args), job_function)(*job_args) |
There was a problem hiding this comment.
When sbc_compassion calls with_delay_sh("run_analyze", wait_for_children=True) without split or parent_job_id, this branch uses with_delay(...).run_analyze() and returns an already-created queue.job record. The next call passes that value as parent_job_id, reaches parent_job.on_done(job), and can crash instead of preserving the old delayable().run_analyze(); job.on_done(after_job).delay() ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.