Repository navigation
[Query] Fix shared exchange account IDs and waiter cleanup - #6
Merged
ColinLeeo merged 1 commit intoOct 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up targets
exchange-fanin-budgetfor apache/iotdb#18869.Eligible fragments registered shared exchange budgets with a query-qualified FI ID, while real exchange handles and cleanup used
fragment.instance. Register the canonical handle account instead, fix the synthetic planner fixtures, and cover aggregate admission, wakeup, and complete cleanup with realSourceHandleinstances.FI teardown also scanned the global pending queue once per fragment. Add a per-FI waiter index and a sequence-ordered global index so cancellation removes relevant requests directly while preserving FIFO wakeups. Cancelled and completed requests leave both indexes; the retry after publishing a waiter and the existing allocation locks remain in place. Successful admission bypasses the waiter indexes. Ordered-map insertion/removal is confined to waiting requests.
Validation:
IoTDBCollectFanInITcases passed with three DataNodes and rebuilt node templates.git diff --checkpassed.