fix: add ToolCall struct, fix parseToolCalls syntax error#23
Merged
Conversation
…ecycle.go - parseToolCalls: removed stray code referencing undefined vars, added calls append + return - types.go: added missing ToolCall struct, kept MCPInvokePayload intact - raw_client.go: added ValidatePrompt method from development - mcp_lifecycle.go: removed NoNewPrivileges (unavailable in std syscall package)
jeanmachuca
force-pushed
the
fix/parse-toolcalls-main
branch
from
f40271b to
b40939f
Compare
- audit.go: check Sscanf, Walk, WriteFile errors - daemon.go: check Unload, Run, Send, WriteFile errors - daemon_test.go: check Unmarshal, WriteFile, MkdirAll errors - handlers.go: check SendToClient, wmClient.Unload errors - mcp_lifecycle.go: check MkdirAll, Encode, Signal, Kill errors; remove unused deniedSyscalls - raw_client.go: check SetDeadline errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Go syntax error in
handlers.go:181breaking CI builds.d.SetState/d.SendToClientcode inparseToolCalls(referenced undefined vars)}()causingunexpected ( at end of statementToolCallstruct to types.gocalls = append(...)andreturn callsto complete the functionMCPInvokePayloadintact (was missingSessionIDafter struct addition)Fixes CI builds in both cognitiveosd and cognitiveos-distro.