fix: publish assets to an existing release and allow a manual run - #16
Merged
Merged
Conversation
The release workflow failed on v0.1.0 at its last step because the release had already been created from the GitHub UI, so the tag push found an existing release and `gh release create` refused. The workflow now keeps a hand-made release's title and notes and only attaches the built assets to it, creating the release from the changelog only when none exists. It also accepts a manual run with a tag name so the assets of an existing release can be attached or refreshed without pushing anything. The releasing guide describes both paths. Signed-off-by: requie <tarique.smith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
v0.1.0release run passed every check and built all assets, then failed at the final step: the release had already been created from the GitHub UI, so the tag push found an existing release andgh release createrefused (a release with the same tag name already exists: v0.1.0). The release therefore has notes but no assets.This change makes the workflow handle that case and adds a way to attach the assets to the existing
v0.1.0release without pushing anything:gh release upload --clobber). Otherwise it creates the release from the changelog as before.workflow_dispatchwith ataginput checks out that tag, runs the same checks and build, and publishes the assets. Running it forv0.1.0after this merges attaches the wheel, sdist, taxonomy JSON and YAML, schemas zip, andSHA256SUMSto the existing release.docs/RELEASING.mddescribes both paths, and the changelog records the fix under Unreleased.Pattern or implementation impact
None. Workflow and docs only; no code, pattern, case, registry, or generated-file changes.
Safety impact
No test content changes. The manual trigger only uploads to a release that already exists for the given tag and runs the full checks on that tag first.
Validation
pushandworkflow_dispatchtriggers