feat(medcat-trainer): Set token expiry for OIDC sessions#543
Merged
jocelyneholdbrook merged 3 commits intoJun 15, 2026
Merged
Conversation
… refresh and use a valid one throughout the session
jocelyneholdbrook
changed the title
alhendrickson
approved these changes
Jun 15, 2026
| # Refresh 60s before the typical 5-minute Keycloak access token lifetime (i.e. 4 minutes from now) | ||
| self._token_expiry = time.monotonic() + 240 | ||
|
|
||
| def ensure_token_fresh(self) -> None: |
Collaborator
There was a problem hiding this comment.
Does this need to be wired in somewhere? Wondering how this is triggered
Contributor
Author
There was a problem hiding this comment.
it can be called by whoever uses this client. The idea is that you check whether the current OIDC token is about to expire, and if so, fetches a new one from Keycloak before the next API call goes out. I will be using it in medcattery's medcat-trainer.py. But in an ideal scenario it should be checked in every medcat-trainer HTTP request but I wanted to avoid making a load of changes at this stage.
…ner_ci (#545) Prevents from silently failing to upload a package with the same version number each time
jocelyneholdbrook
deleted the
feat/medcat-trainer/refresh-auth-token-periodically-in-mctclient
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request implements a token refreshing mechanism for OIDC (OpenID Connect) sessions in the MedCATTrainer client and introduces corresponding unit tests to validate the feature.
This change improves authentication session management and adds robustness to OIDC workflows.