✅ test(api): assert the welcome-version sentinel literally#555
Merged
Conversation
CodeRabbit follow-up on release PR #550: comparing the frame against getVersion() exercised the same mock production calls, so a hard-coded frame value could still pass. Assert the '9.9.9-test' sentinel directly and verify the mocked getVersion was called for the frame.
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
July 17, 2026 10:08
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Portwing WebSocket welcome-frame test now clears Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeRabbit follow-up from release PR #550 (the finding): the welcome-version regression test compared the frame against
getVersion()— the same mock production calls — so a hard-coded frame value could still pass. Now asserts the'9.9.9-test'sentinel literally (after clearing the mock's history) and verifies the mockedgetVersionwas called to produce the frame.Test-only, 5 lines. 98/98 file tests green; full pre-push gate green from a worktree.
✨ Added
9.9.9-testsentinel.getVersionfunction is called during handshake processing.Concerns: