Skip to content

✅ test(watcher): pin fast-path repair of a broken errored reference#554

Merged
scttbnsn merged 1 commit into
dev/v1.6from
feat/v1.6-542-repair-pin
Jul 17, 2026
Merged

✅ test(watcher): pin fast-path repair of a broken errored reference#554
scttbnsn merged 1 commit into
dev/v1.6from
feat/v1.6-542-repair-pin

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

CodeRabbit follow-up from release PR #550 (the finding): the errored-container fast-path tests pinned routing (no getContainers scan) and digest stickiness, but not the repair itself — a silently-skipped repair would still pass.

New test pins the full self-heal contract for an errored container with a broken stored reference: fast-path routing held, tag repaired via resolveTagName (1.2.3 per the helpers fixture — verified by execution), image id updated from inspect, #541 digest stickiness (sha256:reconciled preserved), and the stored error retained until a successful watch clears it.

Test-only, 29 lines (Codex-authored, contract verified by running against the implementation). 56/56 file tests, full docker provider coverage suite green, full pre-push gate green from a worktree.

✨ Added a Docker watcher test covering self-healing for errored containers with broken image references:

  • Verifies fast-path routing without getContainers

  • Confirms tag normalization via resolveTagName

  • Updates the image ID from inspection

  • Preserves sha256:reconciled digest stickiness

  • Retains the stored error until a successful watch clears it

  • Test-only change

  • File tests, Docker provider coverage, and pre-push checks pass

CodeRabbit follow-up on release PR #550: the errored-container fast-path
tests pinned routing and digest stickiness but not the repair itself — a
skipped repair would still pass. The new test pins the full contract: fast
path held (no getContainers scan), tag repaired via resolveTagName, image
id updated from inspect, #541 digest stickiness, and the stored error
retained until a successful watch clears it.
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
drydock-website Ready Ready Preview, Comment Jul 17, 2026 8:00am
drydockdemo-website Ready Ready Preview, Comment Jul 17, 2026 8:00am

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ac765ee8-8829-488c-9d5f-1f0ca69b9281

📥 Commits

Reviewing files that changed from the base of the PR and between 174d62c and ec91f11.

📒 Files selected for processing (1)
  • app/watchers/providers/docker/docker-image-details-orchestration.test.ts

📝 Walkthrough

Walkthrough

Adds a Docker orchestration regression test covering an errored stored container whose image tag is unknown. The test verifies the fast path repairs the tag, image ID, and digest without querying for duplicate containers, while preserving the existing timeout error.

Possibly related PRs

  • CodesWhat/drydock#536: Covers related errored-container fast-path image reference and digest reconciliation behavior.
  • CodesWhat/drydock#547: Overlaps with the same fast-path repair behavior and orchestration expectations.
  • CodesWhat/drydock#550: Targets the same Docker image details orchestration fast-path and repair scenarios.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/v1.6-542-repair-pin

Comment @coderabbitai help to get the list of available commands.

@scttbnsn
scttbnsn merged commit 396d96f into dev/v1.6 Jul 17, 2026
5 checks passed
@scttbnsn
scttbnsn deleted the feat/v1.6-542-repair-pin branch July 17, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant