✅ test(watcher): pin fast-path repair of a broken errored reference#554
Merged
Conversation
CodeRabbit follow-up on release PR #550: the errored-container fast-path tests pinned routing and digest stickiness but not the repair itself — a skipped repair would still pass. The new test pins the full contract: fast path held (no getContainers scan), tag repaired via resolveTagName, image id updated from inspect, #541 digest stickiness, and the stored error retained until a successful watch clears it.
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
July 17, 2026 07:58
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a Docker orchestration regression test covering an errored stored container whose image tag is Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeRabbit follow-up from release PR #550 (the finding): the errored-container fast-path tests pinned routing (no
getContainersscan) and digest stickiness, but not the repair itself — a silently-skipped repair would still pass.New test pins the full self-heal contract for an errored container with a broken stored reference: fast-path routing held, tag repaired via
resolveTagName(1.2.3per the helpers fixture — verified by execution), image id updated from inspect, #541 digest stickiness (sha256:reconciledpreserved), and the stored error retained until a successful watch clears it.Test-only, 29 lines (Codex-authored, contract verified by running against the implementation). 56/56 file tests, full docker provider coverage suite green, full pre-push gate green from a worktree.
✨ Added a Docker watcher test covering self-healing for errored containers with broken image references:
Verifies fast-path routing without
getContainersConfirms tag normalization via
resolveTagNameUpdates the image ID from inspection
Preserves
sha256:reconcileddigest stickinessRetains the stored error until a successful watch clears it
Test-only change
File tests, Docker provider coverage, and pre-push checks pass