Skip to content

✅ test(watcher): pin report emission on the error-restore path#552

Merged
scttbnsn merged 1 commit into
dev/v1.6from
feat/v1.6-550-emit-assertion
Jul 17, 2026
Merged

✅ test(watcher): pin report emission on the error-restore path#552
scttbnsn merged 1 commit into
dev/v1.6from
feat/v1.6-550-emit-assertion

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

CodeRabbit follow-up from release PR #550 (the finding): the getter-TypeError regression manifested as the container report never persisting, so the regression test now also asserts emitContainerReport ran once with the returned report, instead of only checking returned container state.

Test-only, 4 lines. 5/5 tests green; full pre-push gate green from a worktree.

✨ Added

  • Extended the Docker container watcher regression test to verify emitContainerReport is called once with the returned report.

  • Confirmed the container state remains correctly preserved after a getter TypeError.

  • Test-only change.

CodeRabbit follow-up on the rc.2 release PR (#550): the getter-TypeError
regression manifested as the container report never persisting, so the
regression test now asserts emitContainerReport ran with the returned
report instead of only checking returned container state.
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
drydock-website Building Building Preview, Comment Jul 17, 2026 6:05am
drydockdemo-website Ready Ready Preview, Comment Jul 17, 2026 6:05am

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 81268c9f-1717-42af-b233-a6cb6406ffd9

📥 Commits

Reviewing files that changed from the base of the PR and between bb64ba1 and 4086b2e.

📒 Files selected for processing (1)
  • app/watchers/providers/docker/container-processing.test.ts

📝 Walkthrough

Walkthrough

Adds regression assertions to the Docker watchContainer error-preservation test. The test now verifies that emitContainerReport is called exactly once with the report returned by watchContainer, confirming the report-emission path executes after the error.

Possibly related PRs

  • CodesWhat/drydock#551 — Addresses the related watchContainer error-recovery path with getter-safe restore logic.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/v1.6-550-emit-assertion

Comment @coderabbitai help to get the list of available commands.

@scttbnsn
scttbnsn merged commit 42a1a2f into dev/v1.6 Jul 17, 2026
4 of 5 checks passed
@scttbnsn
scttbnsn deleted the feat/v1.6-550-emit-assertion branch July 17, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant