✅ test(watcher): pin report emission on the error-restore path#552
Merged
Conversation
CodeRabbit follow-up on the rc.2 release PR (#550): the getter-TypeError regression manifested as the container report never persisting, so the regression test now asserts emitContainerReport ran with the returned report instead of only checking returned container state.
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
July 17, 2026 06:05
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds regression assertions to the Docker Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeRabbit follow-up from release PR #550 (the finding): the getter-TypeError regression manifested as the container report never persisting, so the regression test now also asserts
emitContainerReportran once with the returned report, instead of only checking returned container state.Test-only, 4 lines. 5/5 tests green; full pre-push gate green from a worktree.
✨ Added
Extended the Docker container watcher regression test to verify
emitContainerReportis called once with the returned report.Confirmed the container state remains correctly preserved after a getter
TypeError.Test-only change.