Skip to content

fix: update spinner to match cc gamut - #34

Merged
LinKCoding merged 2 commits into
mainfrom
kl-gmt-1816-spinner-port
Oct 12, 2026
Merged

LinKCoding merged 2 commits into
mainfrom
kl-gmt-1816-spinner-port

Conversation

@LinKCoding

@LinKCoding LinKCoding commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Ports over work done in: Codecademy/gamut#3440

Updates the Gamut Spinner to match the Codecademy Gamut spinner, replacing the SVG <animateTransform> rotation with a CSS keyframes animation.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1816
  • Changeset added (or empty changeset if no release)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • Package previews from this PR are passing end-to-end tests in all relevant consuming repositories

Testing Instructions

Don't make me tap the sign.

  1. Open the Storybook story for Loading/Spinner (packages/gamut/src/Loading/Spinner.tsx) and confirm the spinner rotates smoothly around its center at 1s per rotation.
  2. Change the size control (for example 24, 48, 100) and confirm the spinner stays centered and doesn't wobble or clip.
  3. Open the story in Safari and confirm the spinner animates.
  4. (Optional) Enable "Reduce motion" in your OS accessibility settings and confirm the rotation slows to 3s per rotation.
  5. Check any component that renders Spinner (for example loading buttons) in light and dark mode and confirm the color follows currentColor.
  6. ...
  7. Profit

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@skillsoft/eslint-plugin-gamut

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/eslint-plugin-gamut@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/eslint-plugin-gamut@34.tgz

@skillsoft/gamut

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut@34.tgz

@skillsoft/gamut-agent-tools

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-agent-tools@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-agent-tools@34.tgz

@skillsoft/gamut-icons

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-icons@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-icons@34.tgz

@skillsoft/gamut-illustrations

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-illustrations@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-illustrations@34.tgz

@skillsoft/gamut-patterns

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-patterns@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-patterns@34.tgz

@skillsoft/gamut-styles

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-styles@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-styles@34.tgz

@skillsoft/gamut-tests

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-tests@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/gamut-tests@34.tgz

@skillsoft/variance

npm i https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/variance@34
yarn add https://pkg.pr.new/Codecademy/skillsoft-gamut/@skillsoft/variance@34.tgz

commit: 7e1051e

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@LinKCoding
LinKCoding marked this pull request as ready for review October 12, 2026 15:16
@LinKCoding
LinKCoding requested a review from a team as a code owner October 12, 2026 15:16
@LinKCoding
LinKCoding merged commit 4f504c9 into main Oct 12, 2026
12 checks passed
@LinKCoding
LinKCoding deleted the kl-gmt-1816-spinner-port branch October 12, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants