Skip to content

fix(Markdown): Escape open video tags - #3442

Draft
dreamwasp wants to merge 2 commits into
mainfrom
cass-gmt-1814-fix
Draft

dreamwasp wants to merge 2 commits into
mainfrom
cass-gmt-1814-fix

Conversation

@dreamwasp

@dreamwasp dreamwasp commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Fixes Markdown rendering breaking on open video tags.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1814
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to the Markdown story
  2. See that the open tags don't break rendering anymore
  3. You can also check out the page in the LE that no longer breaks

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud

nx-cloud Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 2187055


☁️ Nx Cloud last updated this comment at 2026-10-19 13:28:18 UTC

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.85%. Comparing base (a5aad92) to head (54a6cd2).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ckages/gamut/src/Markdown/libs/overrides/utils.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
- Coverage   91.34%   90.85%   -0.49%     
==========================================
  Files         407      277     -130     
  Lines        6873     5949     -924     
  Branches     2210     2020     -190     
==========================================
- Hits         6278     5405     -873     
+ Misses        586      535      -51     
  Partials        9        9              
Flag Coverage Δ
main ?
pull-request 90.85% <92.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 74.0.1-alpha.a24e4a.0 npm diff
@codecademy/gamut-icons 10.2.1-alpha.a24e4a.0 npm diff
@codecademy/gamut-illustrations 1.1.1-alpha.a24e4a.0 npm diff
@codecademy/gamut-kit 3.0.28-alpha.a24e4a.0 npm diff
@codecademy/gamut-patterns 1.1.1-alpha.a24e4a.0 npm diff
@codecademy/gamut-styles 21.2.1-alpha.a24e4a.0 npm diff
@codecademy/gamut-tests 7.1.1-alpha.a24e4a.0 npm diff
@codecademy/variance 1.1.1-alpha.a24e4a.0 npm diff
eslint-plugin-gamut 3.1.1-alpha.a24e4a.0 npm diff

@github-actions

Copy link
Copy Markdown
Contributor

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants