Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 4 | Implement shell tools in python#497
Open
enjoy15 wants to merge 5 commits into
Open
Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 4 | Implement shell tools in python#497enjoy15 wants to merge 5 commits into
enjoy15 wants to merge 5 commits into
Conversation
enjoy15
added
Needs Review
LonMcGregor
reviewed
Jun 3, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but there is some work left to do here.
Is there a package you could use to help with managing arguments? Right now it is a bit complex, and you can't combine single-letter arguments like the command line tools.
| else: | ||
| entries = [name for name in entries if not name.startswith(".")] | ||
|
|
||
| locale.setlocale(locale.LC_COLLATE, "") |
Contributor
There was a problem hiding this comment.
Good idea to consider how this might affect sorting.
Author
There was a problem hiding this comment.
Thanks! I switched argument parsing to argparse and added combined short-flag expansion, so -1a/-a1 work like standard tools.
I also adjusted the -a path so . and .. are included before sorting, keeping sort behavior consistent.
LonMcGregor
added
Reviewed
enjoy15
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all exercises