Manchester | ITP-May-2026 | Szidonia Bodo | Sprint 2 | Wireframe#1391
Open
bodoszidi wants to merge 4 commits into
Open
Manchester | ITP-May-2026 | Szidonia Bodo | Sprint 2 | Wireframe#1391bodoszidi wants to merge 4 commits into
bodoszidi wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
bodoszidi
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
bodoszidi
changed the title
bodoszidi
added
the
Needs Review
akeren
added
Review in progress
akeren
reviewed
Jun 1, 2026
akeren
left a comment
akeren
left a comment
There was a problem hiding this comment.
@bodoszidi, please could you consider restructuring your project files like this:
Wireframe/
├── css/
│ └── style.css
└── img/
├── GitBranch.png
├── Readme.png
└── wireframe.pngThis structure will help keep your project organised by separating your CSS files from your image assets, making the codebase easier to navigate and maintain.
| /* ====== Base Elements ====== | ||
| General rules for basic HTML elements in any context */ | ||
|
|
||
|
|
There was a problem hiding this comment.
@bodoszidi, could you consider removing the second empty line of code?
| margin: 0 auto; | ||
| background-color: rgb(213, 230, 224); | ||
| max-width: 1200px; | ||
| } |
There was a problem hiding this comment.
@bodoszidi, please consider providing a breathing space with a line break at the end of each closing element.
| text-align: center; | ||
| color: rgb(47, 16, 77); | ||
| padding: var(--space); | ||
| } |
There was a problem hiding this comment.
@bodoszidi, the breathing space should be applicable here as well.
| background-color: rgb(221, 149, 191); | ||
| color: black; | ||
| text-decoration: none; | ||
| } |
There was a problem hiding this comment.
@bodoszidi, give some breathing space as described.
Comment on lines
+68
to
84
| } | ||
| .secondrow { | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| > * { | ||
| grid-column: 2/3; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: 20px; | ||
| } | ||
| #readmeimg{ | ||
| display: block; | ||
| margin: 0 auto; | ||
| width: 500px; | ||
| } | ||
| @media (max-width: 800px){ | ||
| .firstrow, .secondrow{ | ||
| display: grid; | ||
| grid-template-columns: 1fr; | ||
| gap: 20px; | ||
| } |
There was a problem hiding this comment.
@bodoszidi, please provide line breaks after each closing element.
akeren
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Update content, add images, and customise CSS layout
Questions
I was not able to revert the changes on the Git terminal -
For next time, I know to always open a new branch from the main branch.