Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Wireframe#1385
Open
Tobias-Amaechina wants to merge 21 commits into
Open
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Wireframe#1385Tobias-Amaechina wants to merge 21 commits into
Tobias-Amaechina wants to merge 21 commits into
Conversation
…proving the alt message for accessiblity compliance
…branch and alt message
… from readme file path section
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Tobias-Amaechina
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Here are what I did
I updated HTML structure to use semantic elements .
I ensured proper heading hierarchy with
for page title and
for article titles![]()
with descriptive alt attributes for accessibility
I used
I implemented three distinct elements for content organization
I added comprehensive alt text to all images for screen reader compatibility
I ensured proper color contrast ratios throughout the design
I verified semantic HTML structure supports assistive technologies
I used meaningful link text ("Read more") for context
I implemented proper heading hierarchy for document outline
I maintained linked style.css file with all styling rules
I organized CSS with clear sections: Design Palette, Base Elements, Site Layout, Grid Layout, and Article Layout
I used CSS custom properties (--color, --space, --container, etc.) for maintainable design system
I committed changes incrementally with descriptive commit messages
I pushed branch to GitHub for code review and collaboration
I followed proper branching strategy for feature development
I created three elements with unique content:
README Purpose - with image, title, summary, and "Read more" link
Wireframe Purpose - with image, title, summary, and "Read more" link
Git Branch Definition - with image, title, summary, and "Read more" link
Each article displays placeholder images with proper styling
Positioned footer with position: fixed; bottom: 0;
Ensured footer remains at bottom of viewport while scrolling content
Added proper bottom margin to main to prevent content overlap
Implemented responsive grid layout matching wireframe design
First article spans full width (grid-column: span 2)
Two-column grid for subsequent articles (grid-template-columns: 1fr 1fr)
Maintained consistent spacing using CSS variables