Skip to content

London | 25-ITP-May | Eyob Zeray | Sprint 1 | Form controls #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eyob-tech wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-May | Eyob Zeray | Sprint 1 | Form controls #1383

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b35052
Add form controls
eyob-tech May 31, 2026
1e930b1
fix light house accessibility score
eyob-tech May 31, 2026
b0004a9
Fix validation errors and improve accessibility
eyob-tech May 31, 2026
eba1696
fix typo in HTML file
eyob-tech May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 66 additions & 24 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,69 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
Copy link
Copy Markdown

@Luro91 Luro91 Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your name to the exercise

</footer>
</body>
<head>
<meta charset="UTF-8">
<title>T-Shirt Order</title>
<style>
Copy link
Copy Markdown

@Luro91 Luro91 Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could you separate the code for the styling from the HTML to make it easier to review (because of smaller files with separate responsibilities)

body {
font-family: Arial, sans-serif;
padding: 20px;
background: #ffffff;
color: #111111;
}
label {
display: block;
margin-top: 16px;
font-weight: bold;
color: #111111;
}
input, select {
width: 100%;
padding: 8px;
margin-top: 4px;
border: 2px solid #111111;
font-size: 1rem;
}
button {
display: block;
margin-top: 20px;
padding: 12px 24px;
background: #8B0000;
color: #ffffff;
border: none;
cursor: pointer;
font-size: 1rem;
font-weight: bold;
}
</style>
</head>
<body>
<main>
<h1>Order a T-Shirt</h1>

<label for="name">Your Name</label>
<input type="text" id="name" name="name" pattern=".*\S.*\S.*" required>
Copy link
Copy Markdown

@Luro91 Luro91 Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any errors or warnings in the browser when I input an incorrect values into the fields. How can you ensure this?


<label for="email">Your Email</label>
<input type="email" id="email" name="email" required>

<label>Colour</label>
<label><input type="radio" name="colour" value="red" required> Red</label>
<label><input type="radio" name="colour" value="blue"> Blue</label>
<label><input type="radio" name="colour" value="black"> Black</label>

<label for="size">Size</label>
<select id="size" name="size" required>
<option value="">Pick a size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>

<button type="submit">Order Now</button>
</main>
</body>
</html>

Loading