Skip to content

London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe#1371

Open
shehu-dona wants to merge 9 commits into
CodeYourFuture:mainfrom
shehu-dona:feature/wireframe
Open

London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe#1371
shehu-dona wants to merge 9 commits into
CodeYourFuture:mainfrom
shehu-dona:feature/wireframe

Conversation

@shehu-dona
Copy link
Copy Markdown

@shehu-dona shehu-dona commented May 30, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Wireframe project completed. It has 2 articles with 3 different images and links.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 30, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c6988db
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1df0cf4b4aa700070c3ed7
😎 Deploy Preview https://deploy-preview-1371--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@shehu-dona shehu-dona changed the title London| May-26 | Liridona Shehu | Sprint-2 | Wireframe London | May-26 | Liridona Shehu | Sprint-2 | Wireframe May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona changed the title London | May-26 | Liridona Shehu | Sprint-2 | Wireframe London | May-26 | Liridona Shehu | Sprint 2| Wireframe May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona changed the title London | May-26 | Liridona Shehu | Sprint 2| Wireframe London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

8 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • To better match the wireframe, can you
    • Keep the page title and text beneath it centered on the page
    • Make the title of articles 2 and 3 fully aligned horizontally
    • Prevent the footer and article content overlap
Image

Comment thread Wireframe/index.html
Comment thread Wireframe/index.html Outdated
Comment thread Wireframe/index.html Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
Make the title of articles 2 and 3 fully aligned horizontally.
Prevent the footer and article content overlap. Added a list
@shehu-dona shehu-dona added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 31, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

  • According to https://validator.w3.org/, there is an error in your code. Can you fix it?

  • Note: If you have not yet enabled "Format on save" in VS Code, consider following this guide to enable VS Code's "Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.


Please also note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 1, 2026
@shehu-dona shehu-dona added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 1, 2026
@shehu-dona
Copy link
Copy Markdown
Author

Hello @cjyuan,

I removed the error in my code.
Also I enabled FormatOnSave.
For the future changes and PR I will follow the recommended steps.

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 1, 2026

Changes look good. Well done.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants