Skip to content

Manchester | 26-ITP-May | Ahmed Elmahmoudi | Sprint 1 | Feature/Form-controls#1367

Open
Alaterry8 wants to merge 8 commits into
CodeYourFuture:mainfrom
Alaterry8:feature/form-controls
Open

Manchester | 26-ITP-May | Ahmed Elmahmoudi | Sprint 1 | Feature/Form-controls#1367
Alaterry8 wants to merge 8 commits into
CodeYourFuture:mainfrom
Alaterry8:feature/form-controls

Conversation

@Alaterry8
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added a name label
  • Added an email label
  • added 3 colour options
  • added 6 size options

@netlify
Copy link
Copy Markdown

netlify Bot commented May 29, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 91c5ee2
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1ae469fb20df00083ca8bc
😎 Deploy Preview https://deploy-preview-1367--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Alaterry8 Alaterry8 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026
@Luro91 Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 30, 2026
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you achieve a lighthouse score of in all categories 100?

Image

Comment thread Form-Controls/index.html
Comment thread Form-Controls/index.html
@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 30, 2026
@Alaterry8
Copy link
Copy Markdown
Author

Hi @Luro91 Thanks for the review, for the SEO score, does it also need to be a 100?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants