Skip to content

Commit 592e39a

Browse files
authored
Reduce disposed skin resource leaks (TurboWarp#27)
1 parent 7d0df87 commit 592e39a

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

‎src/SVGSkin.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class SVGSkin extends Skin {
5656
*/
5757
dispose () {
5858
this.resetMIPs();
59+
this._svgImage.onload = null;
5960
super.dispose();
6061
}
6162

‎src/Skin.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ class Skin {
5959
* Dispose of this object. Do not use it after calling this method.
6060
*/
6161
dispose () {
62+
if (this._emptyImageTexture) {
63+
this._renderer.gl.deleteTexture(this._emptyImageTexture);
64+
this._emptyImageTexture = null;
65+
}
6266
this._id = RenderConstants.ID_NONE;
6367
}
6468

0 commit comments

Comments
 (0)