Skip to content

Commit de8f5ae

Browse files
committed
Fix onClickAddonSettings not being optional
1 parent 04e40ac commit de8f5ae

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

‎src/components/menu-bar/menu-bar.jsx‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,10 @@ class MenuBar extends React.Component {
552552
this.handleClickDesktopSettings
553553
}
554554
// eslint-disable-next-line react/jsx-no-bind
555-
onOpenCustomSettings={this.props.onClickAddonSettings.bind(null, 'editor-theme3')}
555+
onOpenCustomSettings={
556+
this.props.onClickAddonSettings &&
557+
this.props.onClickAddonSettings.bind(null, 'editor-theme3')
558+
}
556559
onRequestClose={this.props.onRequestCloseSettings}
557560
onRequestOpen={this.props.onClickSettings}
558561
settingsMenuOpen={this.props.settingsMenuOpen}

‎src/components/menu-bar/tw-theme-blocks.jsx‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,12 @@ const BlocksThemeMenu = ({
120120
/>
121121
</div>
122122
<Submenu place={isRtl ? 'left' : 'right'}>
123-
{[BLOCKS_THREE, BLOCKS_HIGH_CONTRAST, BLOCKS_DARK, BLOCKS_CUSTOM].map(i => (
123+
{[
124+
BLOCKS_THREE,
125+
BLOCKS_HIGH_CONTRAST,
126+
BLOCKS_DARK,
127+
...(onOpenCustomSettings ? [BLOCKS_CUSTOM] : [])
128+
].map(i => (
124129
<ThemeMenuItem
125130
key={i}
126131
id={i}

0 commit comments

Comments
 (0)