Conversation
There was a problem hiding this comment.
Pull request overview
Updates the refunds documentation to reflect Eupago’s observed “conditionally required” behavior for iban/bic during refunds, reducing failed refund attempts caused by relying on the upstream API docs’ “optional” labeling.
Changes:
- Clarifies that direct-path refund methods (e.g. MB WAY) require no
iban/bic. - Documents that non-direct-path methods (e.g. Multibanco) require an
iban, otherwise Eupago rejects withIBAN_MISSING. - Documents that when
ibanis provided, the matchingbicmust also be provided (no derivation), otherwise Eupago rejects withBIC_INVALID.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76.
Live testing on the sandbox (2026-07-17) confirmed that the refund
ibanandbicfields, while marked optional in Eupago's API docs, are conditionally required: methods without a direct refund path (e.g. Multibanco) reject withIBAN_MISSINGunless an IBAN is given, and an IBAN without its matching BIC is rejected withBIC_INVALID— Eupago does not derive the BIC. Direct-path methods such as MB WAY need neither.This updates
docs/refunds.mdto spell that out, including the rejection codes users will see.