Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds standardized code style (Laravel Pint) and static analysis (Larastan/PHPStan) tooling to the package, aligning contributor workflows and CI with the quality setup described in Issue #23.
Changes:
- Add
laravel/pintandlarastan/larastanas dev dependencies, pluslint,format, andanalyseComposer scripts. - Introduce
pint.json(Laravel preset) and aphpstan.neonconfiguration targetingsrc/with an ignore for the userland-consumedHasApiLogstrait. - Extend CI with a dedicated
qualityjob to run Pint and PHPStan alongside the existing test matrix.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Support/Redactor.php | Switches internal private-method calls to self:: for static analysis correctness and safer resolution. |
| src/Models/ApiLog.php | Adjusts phpdoc inheritance tag formatting for style/tooling compliance. |
| pint.json | Adds Pint configuration using the laravel preset. |
| phpstan.neon | Adds Larastan/PHPStan configuration for static analysis over src/. |
| composer.json | Adds Pint/Larastan dev dependencies and Composer scripts for formatting/linting/analysis. |
| .github/workflows/tests.yml | Adds a new quality CI job running Pint and PHPStan. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Mirrors the quality setup used in codetech/laravel-eupago:
laravel/pint(^1.29) with thelaravelpresetlarastan/larastan(^3.10) at level 5 oversrc/, with an ignore for the userland-consumedHasApiLogstraitlint,format,analysequalityCI job running Pint and PHPStan alongside the test matrixFindings fixed in a separate commit: one Pint phpdoc fix in
ApiLog, andRedactor's private methods are now called viaself::instead ofstatic::.Note: README does not yet document the new commands — that lands after #20 merges to avoid conflicting edits to the Testing section.
Local runs:
composer lint,composer analyseandcomposer test(11 tests, 43 assertions) all pass.