Conversation
There was a problem hiding this comment.
Pull request overview
Updates the v1 branch documentation to make the legacy status and upgrade path clearer, and fixes the vendor:publish command syntax to be portable across shells (notably Windows).
Changes:
- Adds an EOL warning banner and a requirements/status table to the v1 README.
- Updates the
vendor:publishsnippet to use a quoted provider argument with single backslashes. - Adds an
UPGRADE.mdguide covering the 1.x → 2.0 upgrade path and links to the 2.x → 3.0 guide.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Adds EOL + requirements context and updates the vendor:publish command to a Windows-safe provider string format. |
| UPGRADE.md | Introduces an upgrade guide for 1.x → 2.0 and points to the 2.x → 3.0 guide on maintained branches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #16 (merged before this landed): the
vendor:publishsnippet in the v1 README now uses a quoted, single-backslash provider argument — the unquoted doubled-backslash form breaks on Windows shells. Same fix as applied tomainin #17.Fixes
Part of #15 (v1 follow-up).