Repository navigation
feat(vmnetsock): normalize UDP L4 GSO datagrams - #309
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtio UDP_L4 GSO currently stops forwarding in vmnetsock. This PR adds segmentation into complete UDP datagrams for
WithVirtioHeaderConversionandWithPeerVirtioHeaderNormalization.The adapter emits datagrams with
gso_sizebytes of payload, except for a shorter final datagram. The adapter updates IP and UDP lengths, IPv4 IDs, and checksums. UDP segmentation has no connection state and does not require a TCP handshake.DupandClosekeep their existing contracts.Scope
Limits
vmnet.WithInterfaceTSO(true)because the adapter uses that setting for aggregate input and output buffers. Input must fitiface.MaxPacketSize().gso_sizeplus the IP and UDP headers must fit the interface MTU. Oversized values fail before output. Reducinggso_sizewould change UDP datagram boundaries.NEEDS_CSUMwith checksum metadata that matches the UDP header. Output has a complete checksum.UDP_SEGMENT. They do not test USO negotiation by QEMU, VZ, or krunkit virtio NICs.UDP_L4 segmentation follows Virtio 1.3 and the Linux distinction between USO and UFO.