Skip to content

Make ozone diagnostic compatible with CMIP7 data#704

Draft
schlunma wants to merge 8 commits into
Climate-REF:mainfrom
schlunma:update_ozone_diagnostic
Draft

Make ozone diagnostic compatible with CMIP7 data#704
schlunma wants to merge 8 commits into
Climate-REF:mainfrom
schlunma:update_ozone_diagnostic

Conversation

@schlunma
Copy link
Copy Markdown
Contributor

@schlunma schlunma commented Jun 2, 2026

Description

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@schlunma
Copy link
Copy Markdown
Contributor Author

schlunma commented Jun 2, 2026

FYI @hb326

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
core 93.11% <ø> (ø)
providers 91.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ol/src/climate_ref_esmvaltool/diagnostics/ozone.py 92.15% <100.00%> (ø)
...ef-esmvaltool/src/climate_ref_esmvaltool/recipe.py 86.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Make sure only grid cells south of 80N are considered as there are no
# measurements north of 80N in March. Specifying 85N as northern boundary
# in the orignal 'recipe_ref_ozone.yml' is a bug!
# in the orignal 'recipe_ref_ozone_cmip7.yml' is a bug!
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps fix this now that you're updating the recipe anyway?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @axel-lauer and/or @hb326 are on it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just corrected the latitudes in this branch: https://github.com/ESMValGroup/ESMValTool/tree/test_REF_recipe_ozone_with_CMIP7_data
@hb326 kindly agreed to test the changes. If the tests are successful, the modification of the recipe in ozone.py mentioned above can be removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let me know when this is finished, will update the branch here afterwards.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the updated recipe (for CMIP6), and the changes from @axel-lauer did not break it. It ran just fine. So from my side this is good to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants