Repository navigation
Conversation
zlareb1
marked this pull request as ready for review
November 18, 2026 11:48
zlareb1
force-pushed
the
test/sdk-transport-properties
branch
from
November 20, 2026 20:47
66ec282 to
e6aff08
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
force-pushed
the
test/sdk-transport-properties
branch
3 times, most recently
from
November 21, 2026 00:08
7b9e6d2 to
2aeaae4
Compare
…quests Bound the property cases and preserve replay seeds while using mocked fetch and token providers inside the existing SDK test runner. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The configured trial count does not cap additional evaluations while shrinking or replaying a failed example. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep nested credentials visible to the privacy oracle and prove that it rejects an unredacted header even when the original object changes later. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 57327d5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
test/sdk-transport-properties
branch
from
November 21, 2026 01:59
2aeaae4 to
16f42cf
Compare
Retain the reviewed concern while incorporating current main without rewriting its published history. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Retain the reviewed concern while incorporating current main without rewriting its published history. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Retain the transport property suite while incorporating the verified scanner action pin from main. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…-transport-properties Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…der boundaries Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1076
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Bounded generated requests check the TypeScript transport's origin binding, credential handling and request-ID header boundary.
Why
Fixed examples cover selected authentication inputs. Property tests combine URL variants, header casing and bounded strings through public transport requests, checking that rejected origins read no credential, requests select one credential and request IDs remain safe header values. Shrinking records a replayable counterexample when an invariant fails.
Scope and risk
Current main supplies the person-query observation controls and replicated-erasure setup. This branch preserves them unchanged. The diff contains only the feature described below; no production authorization, lease or erasure rule changes.
The SDK adds a pinned development-only property-testing dependency, a suite discovered by the existing test runner and documentation of the boundary checks and replay controls. Each property uses 100 generated trials; failures additionally run shrinking and replay evaluations over bounded inputs. Requests and providers are mocked; no network or live credential is needed. The suite complements existing examples without adding a service, deployment or paid provider dependency. Log checks snapshot complete structured arguments at each call, before later mutation. A leak control verifies that the same privacy assertion rejects a nested credential after the original object is overwritten.
Compatibility, rollout and rollback
LOOM_FUZZ_SEEDandLOOM_FUZZ_PATHfrom a failure and select its test to replay it.Prior-source qualification
The signed normal merge composes current main's hook sandbox cleanup, parser sample context and ingestion failure diagnostics. The whole tree equals main plus the five existing feature entries; every preceding concern and support blob and mode is retained. This source composition does not transfer a prior CI result or review verdict.
On the prior published head, all three generated transport properties and the structured-log leak control pass. Each property runs 100 trials with the default seed and mocked requests. The source check verifies the pinned development dependencies and bounded replay controls. Committed-range whitespace and public-body prose checks pass. Earlier scanner and document-formatting receipts remain historical evidence on unchanged source; those checks were not repeated. The SDK remains excluded by the repository Biome configuration; no excluded-file formatting pass is claimed.
Full SDK typing, the remaining SDK suite, all required hosted CI and a fresh independent whole review are required on the final pushed head. Earlier hosted internationalization and Java parser cost failures retain unknown causes; this composition makes no repair or flake claim. No provider or network request runs locally.
Tests
This composition includes main's grep response fixture and private retirement clock controls. The committed tree preserves every prior concern entry outside those three main paths, with its exact blob and mode. The three main entries match main exactly.
Current local checks pass for the retirement clock's blocked-wait control, syntax of both grep test files, scoped Ruff and formatting of the retirement unit file, public prose and whitespace in the three-path composition. Feature qualification listed above remains historical on unchanged source; those checks were not repeated unless named here. No prior whole review or hosted CI verdict qualifies this head. Full new exact-head hosted CI and a fresh independent whole review remain required before merge. Existing failures and unproven causes remain unresolved; no performance or runtime repair is claimed.
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex traced the transport boundary, wrote the generated requests and reviewed the dependency graph and replay controls.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
Current-main composition preserves independent human administrator approval for proposals and the stored review-provenance field. Focused local checks on this source are recorded separately; fresh whole-source review and complete exact-head hosted CI are required. Earlier CI failures and their unproven causes remain recorded. No previous review or CI pass qualifies this composition.