Skip to content

Transport properties check credential and header boundaries - #858

Open
zlareb1 wants to merge 10 commits into
mainfrom
test/sdk-transport-properties
Open

zlareb1 wants to merge 10 commits into
mainfrom
test/sdk-transport-properties

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Related: #1076

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):

Bounded generated requests check the TypeScript transport's origin binding, credential handling and request-ID header boundary.

Why

Fixed examples cover selected authentication inputs. Property tests combine URL variants, header casing and bounded strings through public transport requests, checking that rejected origins read no credential, requests select one credential and request IDs remain safe header values. Shrinking records a replayable counterexample when an invariant fails.

Scope and risk

Current main supplies the person-query observation controls and replicated-erasure setup. This branch preserves them unchanged. The diff contains only the feature described below; no production authorization, lease or erasure rule changes.

The SDK adds a pinned development-only property-testing dependency, a suite discovered by the existing test runner and documentation of the boundary checks and replay controls. Each property uses 100 generated trials; failures additionally run shrinking and replay evaluations over bounded inputs. Requests and providers are mocked; no network or live credential is needed. The suite complements existing examples without adding a service, deployment or paid provider dependency. Log checks snapshot complete structured arguments at each call, before later mutation. A leak control verifies that the same privacy assertion rejects a nested credential after the original object is overwritten.

Compatibility, rollout and rollback

  • Wire: no operation, field or default changes.
  • Operator steps: none. Set LOOM_FUZZ_SEED and LOOM_FUZZ_PATH from a failure and select its test to replay it.
  • Rollback: removing the development suite and dependency leaves no stored data or runtime changes.

Prior-source qualification

The signed normal merge composes current main's hook sandbox cleanup, parser sample context and ingestion failure diagnostics. The whole tree equals main plus the five existing feature entries; every preceding concern and support blob and mode is retained. This source composition does not transfer a prior CI result or review verdict.

On the prior published head, all three generated transport properties and the structured-log leak control pass. Each property runs 100 trials with the default seed and mocked requests. The source check verifies the pinned development dependencies and bounded replay controls. Committed-range whitespace and public-body prose checks pass. Earlier scanner and document-formatting receipts remain historical evidence on unchanged source; those checks were not repeated. The SDK remains excluded by the repository Biome configuration; no excluded-file formatting pass is claimed.

vitest run src/transport.property.test.ts --maxWorkers=1 --no-file-parallelism

Full SDK typing, the remaining SDK suite, all required hosted CI and a fresh independent whole review are required on the final pushed head. Earlier hosted internationalization and Java parser cost failures retain unknown causes; this composition makes no repair or flake claim. No provider or network request runs locally.

Tests

This composition includes main's grep response fixture and private retirement clock controls. The committed tree preserves every prior concern entry outside those three main paths, with its exact blob and mode. The three main entries match main exactly.

Current local checks pass for the retirement clock's blocked-wait control, syntax of both grep test files, scoped Ruff and formatting of the retirement unit file, public prose and whitespace in the three-path composition. Feature qualification listed above remains historical on unchanged source; those checks were not repeated unless named here. No prior whole review or hosted CI verdict qualifies this head. Full new exact-head hosted CI and a fresh independent whole review remain required before merge. Existing failures and unproven causes remain unresolved; no performance or runtime repair is claimed.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex traced the transport boundary, wrote the generated requests and reviewed the dependency graph and replay controls.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Runtime properties and all required checks pass in CI on the final head.
  • The lock is regenerated; the dependency is development-only.
  • No wire models, migrations, plugin behavior or frontend source change.
  • The architecture and test guide describe the boundary invariants and replay controls.
  • Repository text follows the public-copy rules.
  • Commits are signed off.

Current-main composition preserves independent human administrator approval for proposals and the stored review-provenance field. Focused local checks on this source are recorded separately; fresh whole-source review and complete exact-head hosted CI are required. Earlier CI failures and their unproven causes remain recorded. No previous review or CI pass qualifies this composition.

@zlareb1
zlareb1 marked this pull request as ready for review November 18, 2026 11:48
@zlareb1
zlareb1 force-pushed the test/sdk-transport-properties branch from 66ec282 to e6aff08 Compare November 20, 2026 20:47
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 11:33am UTC

Request Review

@zlareb1
zlareb1 force-pushed the test/sdk-transport-properties branch 3 times, most recently from 7b9e6d2 to 2aeaae4 Compare November 21, 2026 00:08
…quests

Bound the property cases and preserve replay seeds while using mocked fetch and token providers inside the existing SDK test runner.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
The configured trial count does not cap additional evaluations while shrinking or replaying a failed example.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep nested credentials visible to the privacy oracle and prove that it rejects an unredacted header even when the original object changes later.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 57327d5)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the test/sdk-transport-properties branch from 2aeaae4 to 16f42cf Compare November 21, 2026 01:59
Retain the reviewed concern while incorporating current main without rewriting its published history.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Retain the reviewed concern while incorporating current main without rewriting its published history.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Retain the transport property suite while incorporating the verified scanner action pin from main.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…-transport-properties

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…der boundaries

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant