Repository navigation
Tolerate exiting processes in native application checks - #1161
Merged
Merged
Conversation
Treat ESRCH from process observations as a vanished process. Keep permission and other I/O failures terminal, and preserve generation and session ownership checks. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1153
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Not required.
Why
A process can exit after its proc file is opened. Linux then raises ProcessLookupError while reading the file. The native application check treated only FileNotFoundError as a disappeared process, so an unrelated process exiting during a command's session census could abort an otherwise healthy fixture.
Scope and risk
Treat both missing-process errors as an absent observation in process identity, owner and RSS reads. Permission errors and other I/O failures still propagate. Session ownership, process generations, resource limits and cleanup authorization retain their existing checks.
Compatibility, rollout and rollback
Tests
.venv/bin/python -m unittest tests.unit.test_dify_application_guards: all 38 tests pass, including process reuse, orphan ownership, cleanup and monitor refusal controls.git diff --checkpasses.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated (an agent wrote most of the diff): Codex; checked the process observation paths, failure artifact and ownership controls.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
git commit -s).