Repository navigation
Analysis isolation waits for setup publication - #1155
Merged
Merged
Conversation
A Postgres first write answers at commit. Its ClickHouse row can be visible before publication is acknowledged, leaving erasure to wait for an active publisher beyond the fixture request deadline. Wait for the exact setup revision delivery to disappear before erasure, preserving the deadline and all assertions. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Wait for the exact setup revision delivery acknowledgement before erasure. Preserve the client deadline, all isolation assertions and production publisher safety bounds. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1122
Related: #1074
Changelog category
Changelog entry
Not required.
Why
The analysis-isolation test starts erasure when a new row becomes readable. With the Postgres authority, that read can precede publication acknowledgement. Erasure then waits for the outstanding publisher and can outlast the test client's deadline.
Wait for the exact setup revision to finish publication before requesting erasure. The full identity, memory ID and version must match committed rows, and the revision must have no delivery row. A retained settled delivery still blocks.
Scope and risk
One integration fixture changes. The existing write, visibility check, request deadline and isolation assertions remain. The ClickHouse-authority path opens no Postgres connection. No production erasure, lease or publisher bounds change.
Compatibility, rollout and rollback
Tests
python -m pytest tests/integration/test_analysis_isolation.py -k an_erased_user_is_gone_from_the_next_statement -qagainst the configured authenticated test server.AI assistance in the code
AI-generated: Codex wrote the fixture correction and checked revision matching and request order.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist