Skip to content

Surface pending proposals in the Review queue entry and badge; stable Review rail entry - #1153

Open
DeviousCardi wants to merge 2 commits into
ClickHouse:mainfrom
DeviousCardi:fix/review-queue-proposal-counts
Open

DeviousCardi wants to merge 2 commits into
ClickHouse:mainfrom
DeviousCardi:fix/review-queue-proposal-counts

Conversation

@DeviousCardi

Copy link
Copy Markdown

Pending fact proposals (status = 'proposed') did not surface the Review queue in the sidebar or its count: the drawer entry and badge read only conflicts and auto-resolutions, and Review had no stable entry in the ordinary memory workflow. Fixes #1141.

Server — memory.proposals takes count_only (mirroring conflicts.list): one bounded count() over the same scope — no value column, and no scan cap, so a badge/tab count matches the complete authorized queue, not its first page. Accepted/rejected proposals are not pending and never counted. SDK tables (sdk/python, sdk/typescript) and docs/reference/operations/memory.md regenerated via the codegen scripts.

Dashboard

  • The sidebar polls the pending-proposal count (count_only) next to the conflicts count; the Review queue badge is their sum — review items waiting for a person — labeled per kind for screen readers ("5 items to review: 2 conflicts, 3 pending proposals"). A failed read is unknown ("at least …"), never a false zero.
  • Review queue is a stable entry in the rail's Memory group (and the phone's More sheet) for any caller who may view review work — conflicts.list and memory.proposals are both viewer-level, so backend roles are unchanged. A proposal-only queue links straight to ?tab=proposals.
  • Inside the queue: Conflicts and Proposals tabs carry per-kind counts, a proposal-only queue opens on Proposals (empty Conflicts no longer looks like an empty queue), ?tab= deep-links a category, and counts are re-read after a decision and written back to the badge cache.
  • Badge cache keys now carry org, namespace, principal and role, so remembered counts never cross an account or permission boundary.

Tests: server count_only unit tests (query shape: no value column, no LIMIT cap, same filters); frontend tests for the badge math/labels/cache key, rail entry (desktop + mobile sheet), proposal-only deep link, per-kind tab counts, proposal-only default tab, and refresh-after-decision; call-budget updated for the one new bounded count call. pytest (proposals/ops/public-copy suites), vitest focused suites + full suite (failure set identical to base — sandbox timezone/casing artifacts), tsc -b, biome lint/format, ruff, prettier, mypy --strict sdk/python/loom, and all codegen --checks pass.

… Review rail entry

Pending fact proposals (status 'proposed') did not surface the Review queue
in the sidebar or its count: the drawer entry and badge read only conflicts
and auto-resolutions, and Review had no stable entry point in the ordinary
memory workflow.

Server: memory.proposals takes count_only — one bounded count() over the same
scope (no value column, no scan cap), so a badge or tab count matches the
complete authorized queue, not its first page. Accepted/rejected proposals
are not pending and never counted.

Dashboard: the sidebar polls the pending-proposal count (count_only) next to
the conflicts count and badges Review queue with their sum, labeled per kind
for screen readers ('5 items to review: 2 conflicts, 3 pending proposals');
a failed read is unknown ('at least …'), never a false zero, and remembered
badge answers are cached per org, namespace, principal and role. Review queue
is now a stable entry in the rail's Memory group (and the phone's More sheet)
for any role that may view review work — both reads are viewer-level, so
backend roles are unchanged; a proposal-only queue links straight to
?tab=proposals. Inside the queue, the Conflicts and Proposals tabs carry
their per-kind counts, a proposal-only queue opens on Proposals, and counts
are re-read after a decision (written back to the badge cache too).

Fixes ClickHouse#1141
@vercel

vercel Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 22, 2026 10:21am UTC

Request Review

@zlareb1

zlareb1 commented Nov 22, 2026

Copy link
Copy Markdown
Member

@DeviousCardi please attach screenshots as well

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pending proposals do not surface the Review queue or its sidebar count

2 participants