Repository navigation
Surface pending proposals in the Review queue entry and badge; stable Review rail entry - #1153
Open
DeviousCardi wants to merge 2 commits into
Open
DeviousCardi wants to merge 2 commits into
DeviousCardi wants to merge 2 commits into
Conversation
… Review rail entry
Pending fact proposals (status 'proposed') did not surface the Review queue
in the sidebar or its count: the drawer entry and badge read only conflicts
and auto-resolutions, and Review had no stable entry point in the ordinary
memory workflow.
Server: memory.proposals takes count_only — one bounded count() over the same
scope (no value column, no scan cap), so a badge or tab count matches the
complete authorized queue, not its first page. Accepted/rejected proposals
are not pending and never counted.
Dashboard: the sidebar polls the pending-proposal count (count_only) next to
the conflicts count and badges Review queue with their sum, labeled per kind
for screen readers ('5 items to review: 2 conflicts, 3 pending proposals');
a failed read is unknown ('at least …'), never a false zero, and remembered
badge answers are cached per org, namespace, principal and role. Review queue
is now a stable entry in the rail's Memory group (and the phone's More sheet)
for any role that may view review work — both reads are viewer-level, so
backend roles are unchanged; a proposal-only queue links straight to
?tab=proposals. Inside the queue, the Conflicts and Proposals tabs carry
their per-kind counts, a proposal-only queue opens on Proposals, and counts
are re-read after a decision (written back to the badge cache too).
Fixes ClickHouse#1141
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task done
Member
|
@DeviousCardi please attach screenshots as well |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending fact proposals (
status = 'proposed') did not surface the Review queue in the sidebar or its count: the drawer entry and badge read only conflicts and auto-resolutions, and Review had no stable entry in the ordinary memory workflow. Fixes #1141.Server —
memory.proposalstakescount_only(mirroringconflicts.list): one boundedcount()over the same scope — no value column, and no scan cap, so a badge/tab count matches the complete authorized queue, not its first page. Accepted/rejected proposals are not pending and never counted. SDK tables (sdk/python,sdk/typescript) anddocs/reference/operations/memory.mdregenerated via the codegen scripts.Dashboard
count_only) next to the conflicts count; the Review queue badge is their sum — review items waiting for a person — labeled per kind for screen readers ("5 items to review: 2 conflicts, 3 pending proposals"). A failed read is unknown ("at least …"), never a false zero.conflicts.listandmemory.proposalsare both viewer-level, so backend roles are unchanged. A proposal-only queue links straight to?tab=proposals.?tab=deep-links a category, and counts are re-read after a decision and written back to the badge cache.Tests: server
count_onlyunit tests (query shape: no value column, no LIMIT cap, same filters); frontend tests for the badge math/labels/cache key, rail entry (desktop + mobile sheet), proposal-only deep link, per-kind tab counts, proposal-only default tab, and refresh-after-decision; call-budget updated for the one new bounded count call.pytest(proposals/ops/public-copy suites),vitestfocused suites + full suite (failure set identical to base — sandbox timezone/casing artifacts),tsc -b, biome lint/format, ruff, prettier, mypy --strict sdk/python/loom, and all codegen--checks pass.