Repository navigation
Code lookup preserves source coverage and identifier resolution - #1115
Merged
Merged
Conversation
Retain physical class source outside compacted summaries, bind Python import spellings to stored definitions, and admit exact underscore lexemes through the lexical gate without filtering on a SELECT alias. Existing identities and scope predicates remain intact. Retaining class source refreshes the chunk stage. Signed-off-by: Lareb Zafar <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1107
Changelog category (leave one):
Changelog entry (one or two sentences a user of Loom can read without the diff; the release pull request collects these into the release notes):
Code lookup resolves Python import spellings, retains class documentation and data for physical source reads, and finds complete underscore identifiers through the lexical text-index gate.
Why
Retrieval can miss an existing definition when its import spelling omits the physical package module, when compacted class summaries hide the original source, or when the text-index tokenizer splits a stored identifier differently from the query. These changes preserve stored symbol identities and match against retained source and exact lexemes.
Scope and risk
resolved_by: python_module.The source-coordinate helpers come from the linked merged fix. This pull request contains the three additional retrieval fixes and their regression coverage. It makes no measured time, cost or task-success claim.
Compatibility, rollout and rollback
resolved_bycan additionally reportpython_module.Tests
Ready for independent review. The complete local unit gate and hosted checks are not claimed as passing.
make format-check,make lintandmake typecheckpass on the combined source.make test-unittarget is unverified. A complete unit run had an interpreter-path guard failure and a Lua scaling guard failure. The correct checkout virtualenv passes all 62 creator checks; all seven Lua scaling cases pass in isolation, and the previously failing Lua case also passed in the full rerun. That full rerun was stopped before completion, so no passing full-suite result is claimed.AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex implemented the retrieval fixes and regressions. The validation results state the checks completed on the final source.
I can explain every line of this diff and its interaction with retrieval and the extractor stamp.
Checklist