Repository navigation
Conversation
Use the existing manual renewal clock so elapsed CPU time cannot expire the extra search before its blocked fallback starts. Keep the original budgets, assertions and cancellation check. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 of 6 tasks
A new set can answer before its vector is published. Observe the initial active vector before checking that reject copies it at the new head. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…ra-fallback-manual-clock Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…loss Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1105
Related: #995
Changelog category
Changelog entry
Not required.
Why
The fallback timeout test can spend its real 10 ms repository budget before the extra search observes proof loss. It then correctly retains the private base result while the test expects an ordinary rebuild.
The hosted private-base result is consistent with this path; its phase ordering was not traced.
Use the existing manual clock fixture and expire the active repository scope after the blocked fallback renderer starts. Record proof loss and the full original budget at that point, then check them outside the production exception boundary.
Scope and risk
The fallback fixture and a rejection-check setup precondition change; controlled unit cases cover publication ordering. Its 10 ms repository budget, 200 ms watchdog, five original assertions and cancellation cleanup remain. Production search, authorization and fallback behavior are unchanged.
Compatibility, rollout and rollback
No wire, schema, settings or operator changes. Reverting changes only the test fixture.
Prior-source qualification
The signed normal merge composes current main's hook sandbox cleanup, parser sample context and ingestion failure diagnostics. Every prior fallback and rejection-check fixture entry and mode remains unchanged. The whole tree equals main plus the three existing fixture entries. Prior CI and review verdicts do not transfer.
On the prior published head, the four fallback renewal, expiry and cached-result cases pass. The two event-controlled rejection-check setup cases retain their passing historical receipt on unchanged source; they were not repeated. Committed-range whitespace and public prose checks pass. Scoped Ruff and formatting receipts remain historical evidence on unchanged fixture source. No database, provider or runtime starts for these checks.
Historical qualification retains a failing private-base control and a passing control result. Their recorded source hashes differ, and the executed control bytes were not captured before and after. These results do not prove an identical-control run on the final fixture. The rejection-check precondition observes the initial published vector before rejecting it and retains the final rejected-version assertions. The original hosted failure did not expose its actual vector state, so its precise cause remains unproven. The earlier hosted Lua cost failure also retains an unproven cause; this composition makes no performance repair or flake claim. No timing bound or behavior assertion is relaxed.
Fresh independent whole review and full hosted CI are required on the final pushed head.
Tests
This composition includes main's grep response fixture and private retirement clock controls. The committed tree preserves every prior concern entry outside those three main paths, with its exact blob and mode. The three main entries match main exactly.
Current local checks pass for the retirement clock's blocked-wait control, syntax of both grep test files, scoped Ruff and formatting of the retirement unit file, public prose and whitespace in the three-path composition. The existing four focused fallback renewal, expiry and cached-result controls also pass on this head. Feature qualification listed above remains historical on unchanged source; those checks were not repeated unless named here. No prior whole review or hosted CI verdict qualifies this head. Full new exact-head hosted CI and a fresh independent whole review remain required before merge. Existing failures and unproven causes remain unresolved; no performance or runtime repair is claimed.
AI assistance in the code
Checklist
Current-main composition preserves independent human administrator approval for proposals and the stored review-provenance field. Focused local checks on this source are recorded separately; fresh whole-source review and complete exact-head hosted CI are required. Earlier CI failures and their unproven causes remain recorded. No previous review or CI pass qualifies this composition.