Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zlareb1
force-pushed
the
fix/private-log-capture-observation
branch
from
November 21, 2026 00:08
5a604a2 to
0f5fe33
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/private-log-capture-observation
branch
from
November 21, 2026 01:25
0f5fe33 to
92f7309
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
4 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1090
Changelog category
Changelog entry
Not required.
Why
The private native-query test observes a process-wide capture file while awaiting one private query. An unrelated public task can create that file. The event-controlled regression reproduces the original absence failure with only public SQL in the file. The exact writer and contents of the hosted failure remain unknown.
The fixture selects its capture sink with an inherited request context. The request and its children retain the capture boundary; pre-existing unrelated tasks retain their original sink. Forced private captures from the request or a child still fail the original assertion.
Scope and risk
Only the integration capture observer and its unit controls change. The private result, absence assertion, positive public capture control, native query-log proof and SQL and analyst permission checks remain strict. The wrapper delegates to the existing capture writer. No production privacy behavior or permissions change.
Compatibility, rollout and rollback
Tests
Six controls pass on this current-main composition. Scoped Ruff, formatting, prose and committed-range whitespace pass. Both concern files retain their exact prior qualified source, including all original integration assertions. The earlier valid fail-first control produced two original-assertion failures and four passes; the same six pass with the fixture repair.
The fake boundary stops before native database checks. Original hosted capture contents and writer remain unknown; this is no production leak-fix claim. Earlier CI and reviews belong to earlier heads. Fresh independent entire review and complete exact-head hosted CI remain required.
AI assistance in the code
Checklist