Repository navigation
Drive retirement cancellation checks with a private clock - #1053
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 of 5 tasks
zlareb1
force-pushed
the
fix/retirement-request-clock
branch
3 times, most recently
from
November 20, 2026 23:03
d3a956f to
fe4fc36
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures. Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com> (cherry picked from commit 57327d5) Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
fix/retirement-request-clock
branch
from
November 21, 2026 00:19
fe4fc36 to
9c2cc35
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…rivate clock Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category
Changelog entry
Not required.
Why
The retirement cancellation test waits for handler entry with a half-second deadlock watchdog. Keep the cancellation protocol’s timers on a private loop whose clock advances during idle waits, independently of CPU scheduling latency.
Scope and risk
The included person-query observation fixture scopes captured queries to the authorization decision task. Its unbounded-read negative controls remain intact. The replicated-erasure lease fixture and regression are already on main and are preserved unchanged. No production authorization, lease or erasure rule changes.
The retirement change touches one unit-test file. Only the cancellation test and its blocked-wait control use the private function loop. The control verifies that an unfinished wait still times out after half a second. Fixture teardown drains and rejects newly pending tasks.
Every existing test body, assertion and deadline value is retained. Product behavior and shared test helpers are unchanged.
Compatibility, rollout and rollback
Tests
The cancellation protocol and blocked-wait control pass on this composition. The ten inherited person-query observation cases and scoped Ruff and formatting receipts are historical evidence on unchanged source; they were not repeated. Prose and committed-range whitespace checks pass. Every original concern blob and mode is retained. Current main supplies both person-query files, leaving only the retirement test file in this diff.
An earlier report described a retirement failure before the cancellation assertions; its exact original raw receipt has not been located, so that report is unverified here. Earlier attempts to run the new clock control before the fixture change were refused before execution, so no local failing control is claimed. The inherited lexical fixture has a retained historical nine-case passing receipt; its reported failing control also lacks a located raw receipt. The later hosted Lua cost failure has retained raw evidence and remains unexplained. None of these prior results qualifies this head. A fresh independent entire review and all full exact-head hosted workflows must pass before merge.
Focused reproduction:
.venv/bin/python -m pytest -q tests/unit/test_cell_retirement.py::test_production_child_task_cancellation_stays_counted_until_completion tests/unit/test_cell_retirement.py::test_request_clock_keeps_a_blocked_wait_bounded tests/unit/test_scim_person_query_observation.py.AI assistance in the code
AI-generated: Codex wrote the fixture change and checked its clock boundaries, cancellation controls and task cleanup.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
Current-main composition preserves independent human administrator approval for proposals and the stored review-provenance field. Focused local checks on this source are recorded separately; fresh whole-source review and complete exact-head hosted CI are required. Earlier CI failures and their unproven causes remain recorded. No previous review or CI pass qualifies this composition.