Skip to content

Drive retirement cancellation checks with a private clock - #1053

Merged
zlareb1 merged 4 commits into
mainfrom
fix/retirement-request-clock
Nov 21, 2026
Merged

zlareb1 merged 4 commits into
mainfrom
fix/retirement-request-clock

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Changelog category

  • CI Fix or Improvement

Changelog entry

Not required.

Why

The retirement cancellation test waits for handler entry with a half-second deadlock watchdog. Keep the cancellation protocol’s timers on a private loop whose clock advances during idle waits, independently of CPU scheduling latency.

Scope and risk

The included person-query observation fixture scopes captured queries to the authorization decision task. Its unbounded-read negative controls remain intact. The replicated-erasure lease fixture and regression are already on main and are preserved unchanged. No production authorization, lease or erasure rule changes.

The retirement change touches one unit-test file. Only the cancellation test and its blocked-wait control use the private function loop. The control verifies that an unfinished wait still times out after half a second. Fixture teardown drains and rejects newly pending tasks.

Every existing test body, assertion and deadline value is retained. Product behavior and shared test helpers are unchanged.

Compatibility, rollout and rollback

  • Wire, schema, configuration and operator steps: none.
  • Rollback: revert the fixture change. No persisted data changes.

Tests

The cancellation protocol and blocked-wait control pass on this composition. The ten inherited person-query observation cases and scoped Ruff and formatting receipts are historical evidence on unchanged source; they were not repeated. Prose and committed-range whitespace checks pass. Every original concern blob and mode is retained. Current main supplies both person-query files, leaving only the retirement test file in this diff.

An earlier report described a retirement failure before the cancellation assertions; its exact original raw receipt has not been located, so that report is unverified here. Earlier attempts to run the new clock control before the fixture change were refused before execution, so no local failing control is claimed. The inherited lexical fixture has a retained historical nine-case passing receipt; its reported failing control also lacks a located raw receipt. The later hosted Lua cost failure has retained raw evidence and remains unexplained. None of these prior results qualifies this head. A fresh independent entire review and all full exact-head hosted workflows must pass before merge.

Focused reproduction: .venv/bin/python -m pytest -q tests/unit/test_cell_retirement.py::test_production_child_task_cancellation_stays_counted_until_completion tests/unit/test_cell_retirement.py::test_request_clock_keeps_a_blocked_wait_bounded tests/unit/test_scim_person_query_observation.py.

AI assistance in the code

  • AI-generated: Codex wrote the fixture change and checked its clock boundaries, cancellation controls and task cleanup.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Existing assertions and deadline values are retained.
  • No production code, generated interfaces, migrations or operator settings change.
  • Commits are signed off.
  • Full exact-head GitHub CI passes.

Current-main composition preserves independent human administrator approval for proposals and the stored review-provenance field. Focused local checks on this source are recorded separately; fresh whole-source review and complete exact-head hosted CI are required. Earlier CI failures and their unproven causes remain recorded. No previous review or CI pass qualifies this composition.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 10:13am UTC

Request Review

@zlareb1
zlareb1 force-pushed the fix/retirement-request-clock branch 3 times, most recently from d3a956f to fe4fc36 Compare November 20, 2026 23:03
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 57327d5)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/retirement-request-clock branch from fe4fc36 to 9c2cc35 Compare November 21, 2026 00:19
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…rivate clock

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit d188447 into main Nov 21, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant