You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
Updates the standalone JMH benchmark project under performance/: adds support for running benchmarks against a remote ClickHouse server (Cloud or self-hosted) via a new CLICKHOUSE_URL env variable (parsed for scheme/SSL, user-info credentials, port, and an optional cluster=true flag that triggers SYSTEM SYNC REPLICA after writes), replacing the old CLICKHOUSE_HOST/CLICKHOUSE_PORT/CLICKHOUSE_PASSWORD handling in TestEnvironment. It also expands Compression.java with new compression benchmarks (~224 lines) and adds optional codec dependencies (zstd-jni, brotli dec, brotli4j) to the benchmark pom.xml only. README documents the new usage. No shipped library module (clickhouse-data, client-v2, jdbc-v2, etc.) is touched.
No user-facing library API, readers/writers, or release artifacts affected
Concerns
Large-diff High rule fires: 621 additions / 150 deletions across 16 files (>400 LOC) — rubric says request a split (e.g. remote-server support vs. compression benchmarks are two separable strands)
Blast radius is otherwise limited: everything is benchmark tooling, not shipped code, so the high rating is driven purely by diff size
Two bundled concerns in one PR (remote-server execution + compression benchmark suite + new codec deps), and no linked issue (checklist Closes # left unfilled)
Credentials are now taken from URL user-info in an env var; password is not logged (only host:port), acceptable for benchmark tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: